jenkins-bot has submitted this change and it was merged. Change subject: Prevent possible NPE when finding-in-page. ......................................................................
Prevent possible NPE when finding-in-page. https://rink.hockeyapp.net/manage/apps/226649/app_versions/6/crash_reasons/58434226 Change-Id: Idb53015df531b3b8669ae1e4dc6f0b6561111007 --- M app/src/main/java/org/wikipedia/page/PageFragment.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sniedzielski: Looks good to me, approved jenkins-bot: Verified diff --git a/app/src/main/java/org/wikipedia/page/PageFragment.java b/app/src/main/java/org/wikipedia/page/PageFragment.java index 849e420..79fab80 100755 --- a/app/src/main/java/org/wikipedia/page/PageFragment.java +++ b/app/src/main/java/org/wikipedia/page/PageFragment.java @@ -730,6 +730,9 @@ } public void showFindInPage() { + if (model.getPage() == null) { + return; + } final PageActivity pageActivity = getPageActivity(); final FindInPageFunnel funnel = new FindInPageFunnel(app, model.getTitle().getSite(), model.getPage().getPageProperties().getPageId()); -- To view, visit https://gerrit.wikimedia.org/r/257667 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb53015df531b3b8669ae1e4dc6f0b6561111007 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Dbrant <[email protected]> Gerrit-Reviewer: BearND <[email protected]> Gerrit-Reviewer: Brion VIBBER <[email protected]> Gerrit-Reviewer: Mholloway <[email protected]> Gerrit-Reviewer: Niedzielski <[email protected]> Gerrit-Reviewer: Sniedzielski <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
