Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/257674
Change subject: Add NetSpeed property ...................................................................... Add NetSpeed property Add 'NetSpeed' property, which will capture the value of the NetSpeed cookie, * Schema:NavigationTiming: 14899847 > 15033442 (Diff: https://meta.wikimedia.org/w/index.php?diff=15033442&oldid=14899847) * Depend on $.cookie (loaded anyway because it's a requirement for most other extensions, and useful since we're now dealing with at least two cookies.) Change-Id: Ie31ea8b67d41439cc9f2a382992c6fdd481beb51 --- M NavigationTiming.php M modules/ext.navigationTiming.js 2 files changed, 9 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/NavigationTiming refs/changes/74/257674/1 diff --git a/NavigationTiming.php b/NavigationTiming.php index c30ccd1..d58a80f 100644 --- a/NavigationTiming.php +++ b/NavigationTiming.php @@ -44,6 +44,7 @@ 'schema.NavigationTiming', 'schema.SaveTiming', 'json', + 'jquery.cookie', ), 'targets' => array( 'desktop', 'mobile' ), ) @@ -53,7 +54,7 @@ $wgEventLoggingSchemas = array(); } $wgEventLoggingSchemas += array( - 'NavigationTiming' => 14899847, + 'NavigationTiming' => 15033442, 'SaveTiming' => 12236257, ); diff --git a/modules/ext.navigationTiming.js b/modules/ext.navigationTiming.js index eaf2a1f..bf1f4f8 100644 --- a/modules/ext.navigationTiming.js +++ b/modules/ext.navigationTiming.js @@ -114,7 +114,7 @@ function emitNavigationTiming() { var event = { - isHttp2: /(^|; ?)CP=H2/.test( document.cookie ), + isHttp2: /H2/.test( $.cookie( 'CP' ) ), isHiDPI: getDevicePixelRatio() > 1, isAnon: mw.config.get( 'wgUserId' ) === null }, @@ -125,7 +125,12 @@ action: mw.config.get( 'wgAction' ) // view, submit, etc. }, isSpecialPage = !!mw.config.get( 'wgCanonicalSpecialPageName' ), - mobileMode = mw.config.get( 'wgMFMode' ); + mobileMode = mw.config.get( 'wgMFMode' ), + netSpeed = $.cookie( 'NetSpeed' ); + + if ( netSpeed === 'A' || netSpeed === 'B' || netSpeed === 'C' ) { + event.netSpeed = netSpeed; + } if ( window.mediaWikiLoadStart ) { event.mediaWikiLoadComplete = Math.round( mediaWikiLoadEnd - mediaWikiLoadStart ); -- To view, visit https://gerrit.wikimedia.org/r/257674 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie31ea8b67d41439cc9f2a382992c6fdd481beb51 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/NavigationTiming Gerrit-Branch: master Gerrit-Owner: Ori.livneh <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
