jenkins-bot has submitted this change and it was merged. Change subject: Prevent possible NPE when rotating screen with link preview. ......................................................................
Prevent possible NPE when rotating screen with link preview. https://rink.hockeyapp.net/manage/apps/226649/app_versions/6/crash_reasons/57590605 Change-Id: Ifebc435ec9ec981521b0c5c665487a088fd6d6c8 --- M app/src/main/java/org/wikipedia/page/linkpreview/SwipeableBottomDialog.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sniedzielski: Looks good to me, approved Niedzielski: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/app/src/main/java/org/wikipedia/page/linkpreview/SwipeableBottomDialog.java b/app/src/main/java/org/wikipedia/page/linkpreview/SwipeableBottomDialog.java index f94b508..4f947be 100644 --- a/app/src/main/java/org/wikipedia/page/linkpreview/SwipeableBottomDialog.java +++ b/app/src/main/java/org/wikipedia/page/linkpreview/SwipeableBottomDialog.java @@ -117,6 +117,9 @@ @Override public void onConfigurationChanged(Configuration newConfig) { super.onConfigurationChanged(newConfig); + if (getDialog() == null) { + return; + } setWindowLayout(); spaceView.getLayoutParams().height = dialogHeightPx(); -- To view, visit https://gerrit.wikimedia.org/r/257666 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifebc435ec9ec981521b0c5c665487a088fd6d6c8 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Dbrant <[email protected]> Gerrit-Reviewer: BearND <[email protected]> Gerrit-Reviewer: Brion VIBBER <[email protected]> Gerrit-Reviewer: Mholloway <[email protected]> Gerrit-Reviewer: Niedzielski <[email protected]> Gerrit-Reviewer: Sniedzielski <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
