Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/257903
Change subject: Fixed Lint/UnusedBlockArgument RuboCop offense ...................................................................... Fixed Lint/UnusedBlockArgument RuboCop offense See https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars Bug: T117984 Change-Id: Ie4e7204931f70e87303485176a40c68af3d1c31f --- M .rubocop_todo.yml M tests/browser/features/step_definitions/mmv_steps.rb M tests/browser/features/support/pages/commons_page.rb 3 files changed, 2 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer refs/changes/03/257903/1 diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 7ab14ed..1a0a693 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -6,14 +6,6 @@ # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: IgnoreEmptyBlocks. -Lint/UnusedBlockArgument: - Exclude: - - 'tests/browser/features/step_definitions/mmv_steps.rb' - - 'tests/browser/features/support/pages/commons_page.rb' - # Offense count: 26 # Configuration parameters: AllowURI, URISchemes. Metrics/LineLength: diff --git a/tests/browser/features/step_definitions/mmv_steps.rb b/tests/browser/features/step_definitions/mmv_steps.rb index bf95cef..328e68d 100644 --- a/tests/browser/features/step_definitions/mmv_steps.rb +++ b/tests/browser/features/step_definitions/mmv_steps.rb @@ -40,7 +40,7 @@ end When /^I click the image$/ do - on(E2ETestPage) do |page| + on(E2ETestPage) do # Clicking the top-left corner of the image is necessary for the test to work on IE # A plain click on the image element ends up hitting the dialog, which means it won't close begin diff --git a/tests/browser/features/support/pages/commons_page.rb b/tests/browser/features/support/pages/commons_page.rb index 2856874..bc214aa 100644 --- a/tests/browser/features/support/pages/commons_page.rb +++ b/tests/browser/features/support/pages/commons_page.rb @@ -28,7 +28,7 @@ end def log_performance(stats) - stats = stats.reject { |name, value| value.nil? || value.to_s.empty? } + stats = stats.reject { |_name, value| value.nil? || value.to_s.empty? } stats[:duration] = stats[:duration].floor browser.execute_script <<-end_script -- To view, visit https://gerrit.wikimedia.org/r/257903 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie4e7204931f70e87303485176a40c68af3d1c31f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Zfilipin <zfili...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
