BBlack has uploaded a new change for review.
https://gerrit.wikimedia.org/r/258207
Change subject: VCL: no special handling for CentralAutoLogin
......................................................................
VCL: no special handling for CentralAutoLogin
I believe with the recent changes to how session|token cookies and
pass traffic in general are handled, we don't need to do a
backend_random or hash_ignore_busy on all CentralAutoLogin traffic
anymore.
Most of these requests by-volume are shared-cacheable (for ~20
minutes lifetime), and using the normal chash backend should
improve efficiency in general. The uncacheable ones will
chash->fetch->hit-for-pass and then pass for 120s via the
hit-for-pass object using backend_random and not suffer the
problems that hash_ignore_busy is meant to solve.
This also removes the only case in our VCL where we're using
hash_ignore_busy and/or backend_random for non-"pass" traffic in
general.
While I've tried to research the traffic/code and make sure this
won't have a negative impact, should keep an eye out for negative
impacts in terms of 503 rate on particular backends that CAL URLs
for heavy wikis land on and/or perf impact in general. If this
has to be reverted, We could fall back on a more-complicated plan
where we actually "return (pass)" most CAL hits, but not the
commonly-cacheable/cached ones like checkLoggedin?type=script.
Bug: T96847
Change-Id: If210bf2deb31e98bac903f08d7983ccaf9219523
---
M templates/varnish/text-backend.inc.vcl.erb
M templates/varnish/text-frontend.inc.vcl.erb
2 files changed, 0 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/07/258207/1
diff --git a/templates/varnish/text-backend.inc.vcl.erb
b/templates/varnish/text-backend.inc.vcl.erb
index 8a9fc55..5c4ad58 100644
--- a/templates/varnish/text-backend.inc.vcl.erb
+++ b/templates/varnish/text-backend.inc.vcl.erb
@@ -34,13 +34,6 @@
<% end %> // end site_tier == one
- if (req.url ~ "^/wiki/Special:CentralAutoLogin/") {
-<% if @site_tier != "one" -%>
- set req.backend = backend_random;
-<% end -%>
- set req.hash_ignore_busy = true;
- }
-
if (req.request != "GET" && req.request != "HEAD") {
return (pass);
}
diff --git a/templates/varnish/text-frontend.inc.vcl.erb
b/templates/varnish/text-frontend.inc.vcl.erb
index 8e51874..88d27a3 100644
--- a/templates/varnish/text-frontend.inc.vcl.erb
+++ b/templates/varnish/text-frontend.inc.vcl.erb
@@ -127,11 +127,6 @@
unset req.http.If-Modified-Since;
}
- if (req.url ~ "^/wiki/Special:CentralAutoLogin/") {
- set req.backend = backend_random;
- set req.hash_ignore_busy = true;
- }
-
if (req.request != "GET" && req.request != "HEAD") {
return (pass);
}
--
To view, visit https://gerrit.wikimedia.org/r/258207
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If210bf2deb31e98bac903f08d7983ccaf9219523
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
