Jforrester has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/258357

Change subject: Drop support for adding prefix/appendix labels to edit 
tabs/links
......................................................................

Drop support for adding prefix/appendix labels to edit tabs/links

Change-Id: Icebc378f5c00aac57ad361f8ba85da93b8178650
---
M extension.json
M modules/ve-mw/i18n/en.json
M modules/ve-mw/i18n/qqq.json
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
4 files changed, 1 insertion(+), 43 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/57/258357/1

diff --git a/extension.json b/extension.json
index 3919800..0542533 100644
--- a/extension.json
+++ b/extension.json
@@ -53,13 +53,7 @@
                        "editlocaldescriptionsource": 
"visualeditor-ca-editlocaldescriptionsource",
                        "createlocaldescriptionsource": 
"visualeditor-ca-createlocaldescriptionsource",
                        "editsection": null,
-                       "editsectionsource": 
"visualeditor-ca-editsource-section",
-                       "editappendix": null,
-                       "editsourceappendix": null,
-                       "createappendix": null,
-                       "createsourceappendix": null,
-                       "editsectionappendix": null,
-                       "editsectionsourceappendix": null
+                       "editsectionsource": 
"visualeditor-ca-editsource-section"
                },
                "VisualEditorShowBetaWelcome": false,
                "VisualEditorParsoidHTTPProxy": false,
diff --git a/modules/ve-mw/i18n/en.json b/modules/ve-mw/i18n/en.json
index 797e131..e230d8e 100644
--- a/modules/ve-mw/i18n/en.json
+++ b/modules/ve-mw/i18n/en.json
@@ -55,7 +55,6 @@
        "visualeditor-annotationbutton-magiclinknode-tooltip-pmid": "PMID link",
        "visualeditor-annotationbutton-magiclinknode-tooltip-rfc": "RFC link",
        "visualeditor-backbutton-tooltip": "Go back",
-       "visualeditor-beta-appendix": "beta",
        "visualeditor-beta-label": "beta",
        "visualeditor-beta-warning": "You can switch to the wikitext editor at 
any time by clicking on the \"$1\" tab, keeping any changes you have made. If 
you encounter any issues, please report them below.",
        "visualeditor-browserwarning": "You are using a browser which is not 
officially supported by this editor.",
diff --git a/modules/ve-mw/i18n/qqq.json b/modules/ve-mw/i18n/qqq.json
index 2a58ae1..3196b6d 100644
--- a/modules/ve-mw/i18n/qqq.json
+++ b/modules/ve-mw/i18n/qqq.json
@@ -65,7 +65,6 @@
        "visualeditor-annotationbutton-magiclinknode-tooltip-pmid": "Tooltip 
text for link button for PMID magic links.\n\nSee also:\n* 
{{msg-mw|Visualeditor-magiclinknodeinspector-title-pmid}}\n{{Related|Visualeditor-annotationbutton}}",
        "visualeditor-annotationbutton-magiclinknode-tooltip-rfc": "Tooltip 
text for link button for RFC magic links.\n\nSee also:\n* 
{{msg-mw|Visualeditor-magiclinknodeinspector-title-rfc}}\n{{Related|Visualeditor-annotationbutton}}",
        "visualeditor-backbutton-tooltip": "Tooltip text for back button taking 
user to reading mode and closing the editor.\n{{Identical|Go back}}",
-       "visualeditor-beta-appendix": "Used in 
{{msg-mw|Guidedtour-tour-firsteditve-edit-page-description}}.\n{{Identical|Beta}}",
        "visualeditor-beta-label": "Text of tool in the toolbar that highlights 
that VisualEditor is still in beta.\n{{Identical|Beta}}",
        "visualeditor-beta-warning": "Note shown when user clicks on 'beta' 
label in VisualEditor, warning users that the software may have 
issues.\n\nParameters:\n* $1 – the label for the other edit tab.",
        "visualeditor-browserwarning": "Edit notice shown when VisualEditor 
loads, warning users that their browser is not officially supported.",
diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js 
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
index 24c62ed..0c21114 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
@@ -431,22 +431,6 @@
                                        $caVeEdit.addClass( 'collapsible' );
                                }
                        }
-
-                       // Process appendix messages
-                       if ( tabMessages[ action + 'appendix' ] !== null ) {
-                               $caVeEditLink.append(
-                                       $( '<span>' )
-                                               .addClass( 
've-tabmessage-appendix' )
-                                               .text( mw.msg( tabMessages[ 
action + 'appendix' ] ) )
-                               );
-                       }
-                       if ( tabMessages[ action + 'sourceappendix' ] !== null 
) {
-                               $caEditLink.append(
-                                       $( '<span>' )
-                                               .addClass( 
've-tabmessage-appendix' )
-                                               .text( mw.msg( tabMessages[ 
action + 'sourceappendix' ] ) )
-                               );
-                       }
                },
 
                setupSectionLinks: function () {
@@ -497,24 +481,6 @@
                                                }
                                        }
                                } );
-                       }
-
-                       // Process appendix messages
-                       if ( tabMessages.editsectionappendix ) {
-                               $editsections.find( 
'.mw-editsection-visualeditor' )
-                                       .append(
-                                               $( '<span>' )
-                                                       .addClass( 
've-tabmessage-appendix' )
-                                                       .text( mw.msg( 
tabMessages.editsectionappendix ) )
-                                       );
-                       }
-                       if ( tabMessages.editsectionsourceappendix ) {
-                               $editsections.find( 
'a:not(.mw-editsection-visualeditor)' )
-                                       .append(
-                                               $( '<span>' )
-                                                       .addClass( 
've-tabmessage-appendix' )
-                                                       .text( mw.msg( 
tabMessages.editsectionsourceappendix ) )
-                                       );
                        }
 
                        if ( pageCanLoadVE ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/258357
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icebc378f5c00aac57ad361f8ba85da93b8178650
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to