Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/258661

Change subject: Use Database::addQuotes() instead of rolling our own
......................................................................

Use Database::addQuotes() instead of rolling our own

Change-Id: I4d16f61bf2a6177f3e58d65869b98acffc1e986e
---
M includes/specials/SpecialGlobalRenameQueue.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/61/258661/1

diff --git a/includes/specials/SpecialGlobalRenameQueue.php 
b/includes/specials/SpecialGlobalRenameQueue.php
index d077493..8e989cb 100644
--- a/includes/specials/SpecialGlobalRenameQueue.php
+++ b/includes/specials/SpecialGlobalRenameQueue.php
@@ -749,8 +749,9 @@
                                // User requested closed status - either 
approved or rejected
                                $conds['rq_status'] = $status;
                        } else {
+                               $dbr = wfGetDB( DB_SLAVE );
                                // All closed requests
-                               $conds[] = "rq_status <> '" . 
GlobalRenameRequest::PENDING . "'";
+                               $conds[] = 'rq_status <> ' . $dbr->addQuotes( 
GlobalRenameRequest::PENDING );
                        }
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/258661
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d16f61bf2a6177f3e58d65869b98acffc1e986e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to