Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/259284
Change subject: Use ve.ui.Surface#setDisabled
......................................................................
Use ve.ui.Surface#setDisabled
Depends on Id53c98ba in core.
Change-Id: I8a77342447ed402478ea692f9033cc9f61f28c8d
---
M modules/editor/editors/visualeditor/mw.flow.ve.Target.js
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/84/259284/1
diff --git a/modules/editor/editors/visualeditor/mw.flow.ve.Target.js
b/modules/editor/editors/visualeditor/mw.flow.ve.Target.js
index 16b8339..b828f11 100644
--- a/modules/editor/editors/visualeditor/mw.flow.ve.Target.js
+++ b/modules/editor/editors/visualeditor/mw.flow.ve.Target.js
@@ -67,11 +67,9 @@
};
mw.flow.ve.Target.prototype.setDisabled = function ( disabled ) {
- // TODO upstream this to ve.init.Target
var i, len;
for ( i = 0, len = this.surfaces.length; i < len; i++ ) {
- // T106908: ve.ui.Surface doesn't support setDisabled()
- this.surfaces[ i ][ disabled ? 'disable' : 'enable' ]();
+ this.surfaces[ i ].setDisabled( disabled );
}
};
--
To view, visit https://gerrit.wikimedia.org/r/259284
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a77342447ed402478ea692f9033cc9f61f28c8d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
