jenkins-bot has submitted this change and it was merged.
Change subject: Add the agent as a secondary link to Thanks notifications
......................................................................
Add the agent as a secondary link to Thanks notifications
Change-Id: I7d1ed933b23d7b0e69099fa373853a192699d6f7
---
M FlowThanksPresentationModel.php
M ThanksPresentationModel.php
2 files changed, 12 insertions(+), 10 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/FlowThanksPresentationModel.php b/FlowThanksPresentationModel.php
index 8fcea9e..a57b7b4 100644
--- a/FlowThanksPresentationModel.php
+++ b/FlowThanksPresentationModel.php
@@ -34,18 +34,19 @@
);
}
- // TODO add thanking user as secondary link once we can make that look
nice (T115421)
- /*
public function getSecondaryLinks() {
$agent = $this->event->getAgent();
if ( !$agent || !$this->userCan( Revision::DELETED_USER ) ) {
return array();
}
- $url = $agent->getUserPage()->getLocalURL();
return array(
- $url => $agent->getName()
+ array(
+ 'url' => $agent->getUserPage()->getLocalURL(),
+ 'label' => $agent->getName(),
+ 'icon' => 'userAvatar',
+ 'prioritized' => true,
+ )
);
}
- */
}
diff --git a/ThanksPresentationModel.php b/ThanksPresentationModel.php
index f0bcf97..251a6d2 100644
--- a/ThanksPresentationModel.php
+++ b/ThanksPresentationModel.php
@@ -26,18 +26,19 @@
);
}
- // TODO add thanking user as secondary link once we can make that look
nice (T115421)
- /*
public function getSecondaryLinks() {
$agent = $this->event->getAgent();
if ( !$agent || !$this->userCan( Revision::DELETED_USER ) ) {
return array();
}
- $url = $agent->getUserPage()->getLocalURL();
return array(
- $url => $agent->getName()
+ array(
+ 'url' => $agent->getUserPage()->getLocalURL(),
+ 'label' => $agent->getName(),
+ 'icon' => 'userAvatar',
+ 'prioritized' => true,
+ )
);
}
- */
}
--
To view, visit https://gerrit.wikimedia.org/r/259201
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d1ed933b23d7b0e69099fa373853a192699d6f7
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Thanks
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
