Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/259717
Change subject: RuboCop: fixed Style/LeadingCommentSpace offense ...................................................................... RuboCop: fixed Style/LeadingCommentSpace offense Missing space after #. Change-Id: I049fe9df508dec056b69d00d7ca7f5f5ca2fc27d See: https://github.com/bbatsov/ruby-style-guide#hash-space Bug: T112651 --- M .rubocop_todo.yml M modules/base/lib/facter/lldp.rb M modules/base/spec/defines/service_unit_spec.rb M modules/wmflib/lib/hiera/backend/nuyaml_backend.rb M modules/wmflib/lib/hiera/backend/proxy_backend.rb M modules/wmflib/lib/hiera/mwcache.rb 6 files changed, 6 insertions(+), 16 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/17/259717/1 diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 1ad9f5f..c2275d1 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -170,16 +170,6 @@ Style/IndentationWidth: Enabled: false -# Offense count: 6 -# Cop supports --auto-correct. -Style/LeadingCommentSpace: - Exclude: - - 'modules/base/lib/facter/lldp.rb' - - 'modules/base/spec/defines/service_unit_spec.rb' - - 'modules/wmflib/lib/hiera/backend/nuyaml_backend.rb' - - 'modules/wmflib/lib/hiera/backend/proxy_backend.rb' - - 'modules/wmflib/lib/hiera/mwcache.rb' - # Offense count: 15 # Cop supports --auto-correct. Style/MethodCallParentheses: diff --git a/modules/base/lib/facter/lldp.rb b/modules/base/lib/facter/lldp.rb index d9903fb..0031384 100644 --- a/modules/base/lib/facter/lldp.rb +++ b/modules/base/lib/facter/lldp.rb @@ -41,14 +41,14 @@ # VLAN info is also reported by LLDP but for now not parsing it due to some # inconsistencies in reporting depending on vendor and lack of a use case # sample code is provided however - #iface.elements.each('vlan') do |vlan| + # iface.elements.each('vlan') do |vlan| # Facter.add('lldpswport_vlan_%s' % eth) do # confine :kernel => %w{Linux FreeBSD OpenBSD} # setcode do # vlan.text # end # end - #end + # end end # Aggregate all the lldp peers on one single variable diff --git a/modules/base/spec/defines/service_unit_spec.rb b/modules/base/spec/defines/service_unit_spec.rb index 6be090c..00df064 100644 --- a/modules/base/spec/defines/service_unit_spec.rb +++ b/modules/base/spec/defines/service_unit_spec.rb @@ -83,6 +83,6 @@ end end - #MARK + # MARK end end diff --git a/modules/wmflib/lib/hiera/backend/nuyaml_backend.rb b/modules/wmflib/lib/hiera/backend/nuyaml_backend.rb index 33ef086..40c41c4 100644 --- a/modules/wmflib/lib/hiera/backend/nuyaml_backend.rb +++ b/modules/wmflib/lib/hiera/backend/nuyaml_backend.rb @@ -49,7 +49,7 @@ # # === Example # Say you have a lookup for "cluster", and you have -#"regex/%{hostname}" in your hierarchy; also, let's say that your +# "regex/%{hostname}" in your hierarchy; also, let's say that your # scope contains hostname = "web1001.local". So if your regex.yaml # file contains: # diff --git a/modules/wmflib/lib/hiera/backend/proxy_backend.rb b/modules/wmflib/lib/hiera/backend/proxy_backend.rb index b8a77b2..426d0da 100644 --- a/modules/wmflib/lib/hiera/backend/proxy_backend.rb +++ b/modules/wmflib/lib/hiera/backend/proxy_backend.rb @@ -30,7 +30,7 @@ def load_plugins @plugins ||={} - #Load plugins only once + # Load plugins only once @config[:plugins].each do |plugin| Hiera.debug "Loading plugin #{plugin}" begin diff --git a/modules/wmflib/lib/hiera/mwcache.rb b/modules/wmflib/lib/hiera/mwcache.rb index 94d4b1b..5cdeef4 100644 --- a/modules/wmflib/lib/hiera/mwcache.rb +++ b/modules/wmflib/lib/hiera/mwcache.rb @@ -108,7 +108,7 @@ if pages.keys.include? "-1" raise Hiera::MediawikiPageNotFoundError, "Hiera:#{path}" end - #yes, it's that convoluted. + # yes, it's that convoluted. key = pages.keys[0] return pages[key]["revisions"][0] end -- To view, visit https://gerrit.wikimedia.org/r/259717 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I049fe9df508dec056b69d00d7ca7f5f5ca2fc27d Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Zfilipin <zfili...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
