Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/259953
Change subject: Hygiene: Clean up arrow logic for toggling
......................................................................
Hygiene: Clean up arrow logic for toggling
Arrow indicator is same regardless.
open-block decides whether it should be facing up or down
Change-Id: I1de4d438e96503a6d8c0410ead4c308ae1ca8442
---
M resources/mobile.toggle/toggle.js
1 file changed, 6 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/53/259953/1
diff --git a/resources/mobile.toggle/toggle.js
b/resources/mobile.toggle/toggle.js
index f5a5430..da77f37 100644
--- a/resources/mobile.toggle/toggle.js
+++ b/resources/mobile.toggle/toggle.js
@@ -3,14 +3,6 @@
settings = M.require( 'mobile.settings/settings' ),
browser = M.require( 'mobile.browser/browser' ),
escapeHash = M.require( 'mobile.startup/util' ).escapeHash,
- arrowUpOptions = {
- name: 'arrow',
- additionalClassNames: 'indicator'
- },
- arrowDownOptions = {
- name: 'arrow',
- additionalClassNames: 'indicator'
- },
Icon = M.require( 'mobile.startup/Icon' ),
$window = $( window );
@@ -156,15 +148,18 @@
* @ignore
*/
Toggler.prototype.toggle = function ( $heading ) {
- var wasExpanded = $heading.is( '.open-block' ),
+ var indicator,
+ wasExpanded = $heading.is( '.open-block' ),
page = $heading.data( 'page' ),
sectionId = $heading.data( 'section-number' ),
- options, indicator;
+ options = {
+ name: 'arrow',
+ additionalClassNames: 'indicator'
+ };
$heading.toggleClass( 'open-block' );
$heading.data( 'indicator' ).remove();
- options = wasExpanded ? arrowDownOptions : arrowUpOptions;
/**
* @event toggled
*/
--
To view, visit https://gerrit.wikimedia.org/r/259953
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1de4d438e96503a6d8c0410ead4c308ae1ca8442
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
