20after4 has submitted this change and it was merged.
Change subject: Double-encode forward slashes for diffusion
......................................................................
Double-encode forward slashes for diffusion
Diffusion requires double-encoded forward slash, for some reason. Refs T121830
Bug: T121830
Change-Id: I659efec2de331cc398d48e875c1526e5775696d8
---
M GerritProjectController.php
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
20after4: Looks good to me, approved
jenkins-bot: Verified
diff --git a/GerritProjectController.php b/GerritProjectController.php
index 8b87873..4716fe3 100644
--- a/GerritProjectController.php
+++ b/GerritProjectController.php
@@ -1321,9 +1321,11 @@
return new Aphront404Response();
}
$branch = $data['branch'];
- $branch = str_replace('refs/heads','', $branch);
+ // get rid of refs/heads prefix
+ $branch = str_replace('refs/heads', '', $branch);
$branch = trim($branch, '/');
- $branch = urlencode($branch);
+ // double encode any forward slashes in ref.
+ $branch = str_replace('/', '%252F', $branch);
return id(new AphrontRedirectResponse())
->setURI("/diffusion/$CALLSIGN/browse/$branch/");
--
To view, visit https://gerrit.wikimedia.org/r/260026
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I659efec2de331cc398d48e875c1526e5775696d8
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/extensions
Gerrit-Branch: master
Gerrit-Owner: 20after4 <[email protected]>
Gerrit-Reviewer: 20after4 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
