jenkins-bot has submitted this change and it was merged.
Change subject: Force Ace Editor to resize after the dialog has been rendered
......................................................................
Force Ace Editor to resize after the dialog has been rendered
If the editor resizes first, the height is 0px.
Depends on: I48307bd9184b
Bug: T121164
Change-Id: Ieb4ed963b03c9e7d802e9547478eb3c9cde512ae
---
M modules/ve-math/ve.ui.MWMathDialog.js
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Physikerwelt: Looks good to me, but someone else must approve
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-math/ve.ui.MWMathDialog.js
b/modules/ve-math/ve.ui.MWMathDialog.js
index b46d1cc..1ab67af 100644
--- a/modules/ve-math/ve.ui.MWMathDialog.js
+++ b/modules/ve-math/ve.ui.MWMathDialog.js
@@ -228,7 +228,8 @@
return this.symbolsPromise;
}, this )
.next( function () {
- this.input.focus().moveCursorToEnd();
+ // Resize the input once the dialog has been appended
+ this.input.adjustSize( true ).focus().moveCursorToEnd();
}, this );
};
--
To view, visit https://gerrit.wikimedia.org/r/260180
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb4ed963b03c9e7d802e9547478eb3c9cde512ae
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Math
Gerrit-Branch: master
Gerrit-Owner: Tchanders <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Physikerwelt <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
