Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/260548
Change subject: Add/move missing/misplaced class documentation blocks ...................................................................... Add/move missing/misplaced class documentation blocks With this intentionally minimal patch all classes do have the most basic documentation block. Change-Id: I67603ea226590ea3e138310b7d0df2a63ceff2b0 --- M client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseEntityLibrary.php M client/includes/Hooks/ParserFunctionRegistrant.php M lib/tests/phpunit/store/ChunkCacheTest.php M repo/includes/Diff/ClaimDifference.php M repo/includes/Search/Elastic/Fields/WikibaseFieldDefinitions.php M repo/maintenance/dumpJson.php M repo/maintenance/dumpRdf.php M repo/maintenance/importProperties.php M view/src/Module/TemplateModule.php 9 files changed, 31 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/48/260548/1 diff --git a/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseEntityLibrary.php b/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseEntityLibrary.php index 88c9b9c..b9b6c13 100644 --- a/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseEntityLibrary.php +++ b/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseEntityLibrary.php @@ -24,7 +24,6 @@ * @license GNU GPL v2+ * @author Marius Hoch < h...@online.de > */ - class Scribunto_LuaWikibaseEntityLibrary extends Scribunto_LuaLibraryBase { /** diff --git a/client/includes/Hooks/ParserFunctionRegistrant.php b/client/includes/Hooks/ParserFunctionRegistrant.php index 96bed0e..39ed082 100644 --- a/client/includes/Hooks/ParserFunctionRegistrant.php +++ b/client/includes/Hooks/ParserFunctionRegistrant.php @@ -6,6 +6,12 @@ use PPFrame; use Wikibase\Client\DataAccess\PropertyParserFunction\Runner; +/** + * @since 0.5 + * + * @licence GNU GPL v2+ + * @author Katie Filbert < aude.w...@gmail.com > + */ class ParserFunctionRegistrant { /** diff --git a/lib/tests/phpunit/store/ChunkCacheTest.php b/lib/tests/phpunit/store/ChunkCacheTest.php index be72678..7308c08 100644 --- a/lib/tests/phpunit/store/ChunkCacheTest.php +++ b/lib/tests/phpunit/store/ChunkCacheTest.php @@ -13,7 +13,6 @@ * @licence GNU GPL v2+ * @author Daniel Kinzler */ - class ChunkCacheTest extends \MediaWikiTestCase { protected static function getTestData() { diff --git a/repo/includes/Diff/ClaimDifference.php b/repo/includes/Diff/ClaimDifference.php index 407295a..80d3366 100644 --- a/repo/includes/Diff/ClaimDifference.php +++ b/repo/includes/Diff/ClaimDifference.php @@ -8,6 +8,7 @@ /** * Represents the difference between two Statement objects. + * @fixme Contains references and rank? It's a StatementDifference! * * @since 0.4 * @@ -15,7 +16,6 @@ * @author Tobias Gritschacher < tobias.gritschac...@wikimedia.de > * @author Thiemo Mättig */ -// FIXME: Contains references and rank? It's a StatementDifference! class ClaimDifference implements Comparable { /** diff --git a/repo/includes/Search/Elastic/Fields/WikibaseFieldDefinitions.php b/repo/includes/Search/Elastic/Fields/WikibaseFieldDefinitions.php index 89b42c2..a066e2a 100644 --- a/repo/includes/Search/Elastic/Fields/WikibaseFieldDefinitions.php +++ b/repo/includes/Search/Elastic/Fields/WikibaseFieldDefinitions.php @@ -2,6 +2,12 @@ namespace Wikibase\Repo\Search\Elastic\Fields; +/** + * @since 0.5 + * + * @licence GNU GPL v2+ + * @author Katie Filbert < aude.w...@gmail.com > + */ class WikibaseFieldDefinitions { /** diff --git a/repo/maintenance/dumpJson.php b/repo/maintenance/dumpJson.php index 7f7d689..9a9e0ae 100644 --- a/repo/maintenance/dumpJson.php +++ b/repo/maintenance/dumpJson.php @@ -15,6 +15,13 @@ require_once __DIR__ . '/dumpEntities.php'; +/** + * @since 0.5 + * + * @licence GNU GPL v2+ + * @author Daniel Kinzler + * @author Adam Shorland + */ class DumpJson extends DumpScript { /** diff --git a/repo/maintenance/dumpRdf.php b/repo/maintenance/dumpRdf.php index 75a6314..66ab8c7 100644 --- a/repo/maintenance/dumpRdf.php +++ b/repo/maintenance/dumpRdf.php @@ -15,6 +15,13 @@ require_once __DIR__ . '/dumpEntities.php'; +/** + * @since 0.5 + * + * @licence GNU GPL v2+ + * @author Stas Malyshev + * @author Adam Shorland + */ class DumpRdf extends DumpScript { /** diff --git a/repo/maintenance/importProperties.php b/repo/maintenance/importProperties.php index 8f9b7af..11c1d9c 100644 --- a/repo/maintenance/importProperties.php +++ b/repo/maintenance/importProperties.php @@ -9,6 +9,10 @@ use Wikibase\Lib\Store\EntityStore; use Wikibase\Repo\WikibaseRepo; +$basePath = getenv( 'MW_INSTALL_PATH' ) !== false ? getenv( 'MW_INSTALL_PATH' ) : __DIR__ . '/../../../..'; + +require_once $basePath . '/maintenance/Maintenance.php'; + /** * Maintenance script for importing properties in Wikidata. * @@ -26,11 +30,6 @@ * @author Nikola Smolenski <smole...@eunet.rs> * @author Jens Ohlig < jens.oh...@wikimedia.de > */ - -$basePath = getenv( 'MW_INSTALL_PATH' ) !== false ? getenv( 'MW_INSTALL_PATH' ) : __DIR__ . '/../../../..'; - -require_once $basePath . '/maintenance/Maintenance.php'; - class ImportProperties extends Maintenance { /** diff --git a/view/src/Module/TemplateModule.php b/view/src/Module/TemplateModule.php index 102f4b4..ee14bbf 100644 --- a/view/src/Module/TemplateModule.php +++ b/view/src/Module/TemplateModule.php @@ -15,7 +15,6 @@ * @licence GNU GPL v2+ * @author H. Snater <mediaw...@snater.com> */ - class TemplateModule extends ResourceLoaderFileModule { /** -- To view, visit https://gerrit.wikimedia.org/r/260548 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I67603ea226590ea3e138310b7d0df2a63ceff2b0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits