jenkins-bot has submitted this change and it was merged.
Change subject: Make notification body text lighter
......................................................................
Make notification body text lighter
Use #888 instead of #666 to match secondary link text
(which is #000 with 50% opacity), both in the flyout and
on the special page.
Bonus: use LESS variables for these colors.
Change-Id: Ifc1182a001e9b25f6ff7c213b6fcde3dc2f0acd2
---
M modules/echo.variables.less
M modules/nojs/mw.echo.notifications.less
M modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
3 files changed, 20 insertions(+), 4 deletions(-)
Approvals:
Sbisson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/echo.variables.less b/modules/echo.variables.less
index 55f5bef..aeea02f 100644
--- a/modules/echo.variables.less
+++ b/modules/echo.variables.less
@@ -6,6 +6,9 @@
@notification-background-unread: white;
@notification-background-read: #f1f1f1;
+@notification-text-color: #666;
+@notification-body-color: #888;
+
@notification-popup-width: 450px;
@opacity-low: 0.5;
diff --git a/modules/nojs/mw.echo.notifications.less
b/modules/nojs/mw.echo.notifications.less
index f309ebb..e0051da 100644
--- a/modules/nojs/mw.echo.notifications.less
+++ b/modules/nojs/mw.echo.notifications.less
@@ -1,3 +1,5 @@
+@import '../echo.variables';
+
// This needs to be outside the upper selector 'NotificationItemWidget'
// because the same styles also apply (for the moment, at least) to the
notification
// objects in the Special:Notifications page, which are, individually
@@ -50,9 +52,16 @@
overflow: hidden;
display: block;
+ .mw-echo-title {
+ color: @notification-text-color;
+ }
+
+ .mw-echo-payload {
+ color: @notification-body-color;
+ }
+
.mw-echo-title,
.mw-echo-payload {
- color: #666666;
font-size: 1em;
line-height: 1.4em;
diff --git a/modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
b/modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
index fbcf330..753f07a 100644
--- a/modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
+++ b/modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
@@ -10,12 +10,12 @@
&:hover > a {
text-decoration: none;
- color: #666666;
+ color: @notification-text-color;
}
&:not(:hover) a,
#p-personal &:not(:hover) a.new {
- color: #666666;
+ color: @notification-text-color;
}
&:last-child {
@@ -38,8 +38,12 @@
box-sizing: border-box;
width: 100%;
- // Only for bundled items
&-message {
+ &-body {
+ color: @notification-body-color;
+ }
+
+ // Only for bundled items
.mw-echo-ui-notificationItemWidget-bundle & {
float: left;
display: inline-block;
--
To view, visit https://gerrit.wikimedia.org/r/260058
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc1182a001e9b25f6ff7c213b6fcde3dc2f0acd2
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Pginer <pgi...@wikimedia.org>
Gerrit-Reviewer: Sbisson <sbis...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
