jenkins-bot has submitted this change and it was merged. Change subject: Decrease tablet threshold to 720px ......................................................................
Decrease tablet threshold to 720px Account for devices such as Samsung Galaxy S5 Mini Bug: T78174 Change-Id: Id3d750b854a998615432f08afe01375e96ebaae5 --- M includes/config/Site.php M tests/browser/features/step_definitions/common_steps.rb 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Bmansurov: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/config/Site.php b/includes/config/Site.php index 85a225f..5d4f52a 100644 --- a/includes/config/Site.php +++ b/includes/config/Site.php @@ -31,8 +31,9 @@ /** * Minimum available screen width at which a device can be considered a tablet/desktop + * The number is currently based on the device width of a Samsung Galaxy S5 mini. */ -$wgMFDeviceWidthTablet = 768; +$wgMFDeviceWidthTablet = 720; /** * Template for mobile URLs. diff --git a/tests/browser/features/step_definitions/common_steps.rb b/tests/browser/features/step_definitions/common_steps.rb index e460af6..08f7043 100644 --- a/tests/browser/features/step_definitions/common_steps.rb +++ b/tests/browser/features/step_definitions/common_steps.rb @@ -68,7 +68,7 @@ end Given(/^I am viewing the site in tablet mode$/) do - # Use numbers significantly larger than 768px to account for browser chrome + # Use numbers significantly larger than tablet threshold to account for browser chrome browser.window.resize_to(1280, 1024) end -- To view, visit https://gerrit.wikimedia.org/r/260510 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3d750b854a998615432f08afe01375e96ebaae5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Bmansurov <bmansu...@wikimedia.org> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
