jenkins-bot has submitted this change and it was merged.
Change subject: Remove mediawiki.special.javaScriptTest module
......................................................................
Remove mediawiki.special.javaScriptTest module
We're almost ready to drop the non-plain mode of Special:JavaScriptTest
in favour of Special:JavaScript/qunit/plain. There's a few mobile-related
extensions still using the non-karma mode for qunit testing.
However, none of them make use of the Skin selector, which was mainly a debug
thing I added in the initial version. It no longer makes sense since our tests
now enforce an anti-dependency on skin html and other context. Encouraging
testing in multiple skins in the old UI therefore no longer makes sense.
This also fixes one of the most frequent errors in resourceloader logs and gets
rid of an ugly hack in Resources.php that causes a small amount of overhead
in ResourceLoader::__construct().
> MessageBlobStore failed to find skinname-fallback
> MessageBlobStore failed to find skinname-apioutput
Change-Id: Idaacf718703883c6a7e83a17ccd3f41ebdca53d1
---
M includes/specials/SpecialJavaScriptTest.php
M resources/Resources.php
D resources/src/mediawiki.special/mediawiki.special.javaScriptTest.js
3 files changed, 0 insertions(+), 49 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialJavaScriptTest.php
b/includes/specials/SpecialJavaScriptTest.php
index fbdefea..bb35130 100644
--- a/includes/specials/SpecialJavaScriptTest.php
+++ b/includes/specials/SpecialJavaScriptTest.php
@@ -106,8 +106,6 @@
return;
}
- $out->addModules( 'mediawiki.special.javaScriptTest' );
-
$method = 'view' . ucfirst( $framework );
$this->$method();
$out->setPageTitle( $this->msg(
diff --git a/resources/Resources.php b/resources/Resources.php
index c66dcb2..26a5ea5 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1866,16 +1866,6 @@
'mediawiki.special.watchlist' => array(
'scripts' =>
'resources/src/mediawiki.special/mediawiki.special.watchlist.js',
),
- 'mediawiki.special.javaScriptTest' => array(
- 'scripts' =>
'resources/src/mediawiki.special/mediawiki.special.javaScriptTest.js',
- 'messages' => array_merge( Skin::getSkinNameMessages(), array(
- 'colon-separator',
- 'javascripttest-pagetext-skins',
- ) ),
- 'dependencies' => 'mediawiki.Uri',
- 'position' => 'top',
- 'targets' => array( 'desktop', 'mobile' ),
- ),
'mediawiki.special.version' => array(
'styles' =>
'resources/src/mediawiki.special/mediawiki.special.version.css',
),
diff --git
a/resources/src/mediawiki.special/mediawiki.special.javaScriptTest.js
b/resources/src/mediawiki.special/mediawiki.special.javaScriptTest.js
deleted file mode 100644
index fb74e4e..0000000
--- a/resources/src/mediawiki.special/mediawiki.special.javaScriptTest.js
+++ /dev/null
@@ -1,37 +0,0 @@
-/*!
- * JavaScript for Special:JavaScriptTest
- */
-( function ( mw, $ ) {
- $( function () {
-
- // Create useskin dropdown menu and reload onchange to the
selected skin
- // (only if a framework was found, not on error pages).
- $( '#mw-javascripttest-summary' ).append( function () {
-
- var $html = $( '<p><label for="useskin">'
- + mw.message(
'javascripttest-pagetext-skins' ).escaped()
- + ' '
- + '</label></p>' ),
- select = '<select name="useskin" id="useskin">';
-
- // Build <select> further
- $.each( mw.config.get( 'wgAvailableSkins' ), function (
id ) {
- select += '<option value="' + id + '"'
- + ( mw.config.get( 'skin' ) === id ? '
selected="selected"' : '' )
- + '>' + mw.message( 'skinname-' + id
).escaped() + '</option>';
- } );
- select += '</select>';
-
- // Bind onchange event handler and append to form
- $html.append(
- $( select ).change( function () {
- var url = new mw.Uri();
- location.href = url.extend( { useskin:
$( this ).val() } );
- } )
- );
-
- return $html;
- } );
- } );
-
-}( mediaWiki, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/260092
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idaacf718703883c6a7e83a17ccd3f41ebdca53d1
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Edokter <er...@darcoury.nl>
Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
