jenkins-bot has submitted this change and it was merged.

Change subject: Improved handling of newline as delimiter
......................................................................


Improved handling of newline as delimiter

Change-Id: I1aec8b9f2bfd3bbd4dba1e7280d777124d326a92
---
M CargoFieldDescription.php
1 file changed, 2 insertions(+), 5 deletions(-)

Approvals:
  Yaron Koren: Checked; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/CargoFieldDescription.php b/CargoFieldDescription.php
index b824511..982826a 100644
--- a/CargoFieldDescription.php
+++ b/CargoFieldDescription.php
@@ -114,11 +114,8 @@
        }
 
        function getDelimiter() {
-               // Make "\n" represent a newline
-               if ( $this->mDelimiter == '\n' ) {
-                       return "\n";
-               }
-               return $this->mDelimiter;
+               // Make "\n" represent a newline.
+               return str_replace( '\n', "\n", $this->mDelimiter );
        }
 
        function setDelimiter( $delimiter ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/260851
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1aec8b9f2bfd3bbd4dba1e7280d777124d326a92
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <[email protected]>
Gerrit-Reviewer: Yaron Koren <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to