Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/260888
Change subject: Upgrade mismatched commit() warnings to exceptions
......................................................................
Upgrade mismatched commit() warnings to exceptions
I saw no WMF logs for these in the last 7 days.
Change-Id: I725535925ba3fc68cee485767f18937fb8f239bf
---
M includes/db/Database.php
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/88/260888/1
diff --git a/includes/db/Database.php b/includes/db/Database.php
index 31e2653..a93f792 100644
--- a/includes/db/Database.php
+++ b/includes/db/Database.php
@@ -3563,7 +3563,10 @@
if ( !$this->mTrxLevel ) {
return; // nothing to do
} elseif ( !$this->mTrxAutomatic ) {
- wfWarn( "$fname: Flushing an explicit
transaction, getting out of sync!" );
+ throw new DBUnexpectedError(
+ $this,
+ "$fname: Flushing an explicit
transaction, getting out of sync!"
+ );
}
} else {
if ( !$this->mTrxLevel ) {
--
To view, visit https://gerrit.wikimedia.org/r/260888
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I725535925ba3fc68cee485767f18937fb8f239bf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
