Mattflaschen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/260901
Change subject: Have foreachwiki exit with non-zero status if any wiki fails
......................................................................
Have foreachwiki exit with non-zero status if any wiki fails
This allows puppet to detect the error here, rather than make it look
like a later step is at fault or there is an ordering problem.
Change-Id: Ia6563ce21002bfedac8ddd36475172b76a22e5a2
---
M puppet/modules/mediawiki/templates/multiwiki/foreachwiki.erb
1 file changed, 12 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant
refs/changes/01/260901/1
diff --git a/puppet/modules/mediawiki/templates/multiwiki/foreachwiki.erb
b/puppet/modules/mediawiki/templates/multiwiki/foreachwiki.erb
index 3453288..b07084b 100755
--- a/puppet/modules/mediawiki/templates/multiwiki/foreachwiki.erb
+++ b/puppet/modules/mediawiki/templates/multiwiki/foreachwiki.erb
@@ -6,10 +6,20 @@
CMD=$1
shift
+failed_wiki_count=0
for db in $(alldbs); do
echo -----------------------------------------------------------------
echo $db
echo -----------------------------------------------------------------
- mwscript "$CMD" --wiki=$db "$@" |
- sed -u "s/^/$db: /"
+ mwscript "$CMD" --wiki=$db "$@" | sed -u "s/^/$db: /"
+ if [ ${PIPESTATUS[0]} -ne 0 ];
+ then
+ ((failed_wiki_count++))
+ fi
done
+
+if [ $failed_wiki_count -ne 0 ];
+then
+ echo "$failed_wiki_count wikis failed." >&2
+ exit 1
+fi
--
To view, visit https://gerrit.wikimedia.org/r/260901
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6563ce21002bfedac8ddd36475172b76a22e5a2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
