jenkins-bot has submitted this change and it was merged.
Change subject: Disable Preferences save button if settings have not changed
......................................................................
Disable Preferences save button if settings have not changed
Disable the Special:Preferences 'Save' button if no
settings have been changed. This prevents unnecessary saving when
you can't remember if you saved the settings or not.
Uses new check for preference change to prevent disabling the button
if the user makes preferences changes before JS is done loading.
Bug: T89457
Change-Id: I1064c5e76a3c1f856b9b9288baaf39cc102edf8a
---
M resources/src/mediawiki.special/mediawiki.special.preferences.js
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
TheDJ: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki.special/mediawiki.special.preferences.js
b/resources/src/mediawiki.special/mediawiki.special.preferences.js
index 7f3de38..c2b9a4f 100644
--- a/resources/src/mediawiki.special/mediawiki.special.preferences.js
+++ b/resources/src/mediawiki.special/mediawiki.special.preferences.js
@@ -295,6 +295,15 @@
return false;
}
+ // Disable the button to save preferences unless preferences
have changed
+ // Check if preferences have been changed before JS has
finished loading
+ if ( !isPrefsChanged() ) {
+ $( '#prefcontrol' ).prop( 'disabled', true );
+ $( '#preferences > fieldset' ).one( 'change keydown
mousedown', function () {
+ $( '#prefcontrol' ).prop( 'disabled', false );
+ } );
+ }
+
// Set up a message to notify users if they try to leave the
page without
// saving.
allowCloseWindow = mw.confirmCloseWindow( {
--
To view, visit https://gerrit.wikimedia.org/r/255712
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1064c5e76a3c1f856b9b9288baaf39cc102edf8a
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Sn1per <geof...@gmail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Edokter <er...@darcoury.nl>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Jaredzimmerman <jared.zimmer...@wikimedia.org>
Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
