Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/261870
Change subject: Remove instance caching in getWPBConfig()
......................................................................
Remove instance caching in getWPBConfig()
ConfigFactory already instance caches it.
Change-Id: I0755491ca42c40ac99d4e297bcfadec123fb8812
---
M includes/WikidataPageBanner.functions.php
1 file changed, 2 insertions(+), 7 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner
refs/changes/70/261870/1
diff --git a/includes/WikidataPageBanner.functions.php
b/includes/WikidataPageBanner.functions.php
index 92101ed..e5e01c8 100644
--- a/includes/WikidataPageBanner.functions.php
+++ b/includes/WikidataPageBanner.functions.php
@@ -6,8 +6,6 @@
*/
class WikidataPageBannerFunctions {
- private static $wpbConfig = null;
-
/**
* @var string[] name of skins that do not implement 'prebodyhtml'
* banners for these skin will be prepended to body content
@@ -314,11 +312,8 @@
* @return Config
*/
public static function getWPBConfig() {
- if ( self::$wpbConfig === null ) {
- self::$wpbConfig =
ConfigFactory::getDefaultInstance()->makeConfig( 'wikidatapagebanner' );
- }
-
- return self::$wpbConfig;
+ return ConfigFactory::getDefaultInstance()
+ ->makeConfig( 'wikidatapagebanner' );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/261870
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0755491ca42c40ac99d4e297bcfadec123fb8812
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
