jenkins-bot has submitted this change and it was merged. Change subject: Add missing type hints and documentation to Babel class ......................................................................
Add missing type hints and documentation to Babel class Change-Id: I216f8dd626b938bd3c43b97f18bdeb28eb6f4265 --- M Babel.class.php 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Nikerabbit: Looks good to me, approved jenkins-bot: Verified diff --git a/Babel.class.php b/Babel.class.php index 0e4e117..e43957f 100644 --- a/Babel.class.php +++ b/Babel.class.php @@ -25,10 +25,11 @@ /** * Render the Babel tower. * - * @param $parser Parser. + * @param Parser $parser + * @param string [$parameter,...] * @return string: Babel tower. */ - public static function Render( $parser ) { + public static function Render( Parser $parser ) { global $wgBabelUseUserLanguage; $parameters = func_get_args(); array_shift( $parameters ); @@ -138,9 +139,9 @@ /** * Performs a link batch on a series of templates. * - * @param $parameters Array: Templates to perform the link batch on. + * @param string[] $parameters Templates to perform the link batch on. */ - protected static function mTemplateLinkBatch( $parameters ) { + protected static function mTemplateLinkBatch( array $parameters ) { $titles = array(); foreach ( $parameters as $name ) { $title = Title::newFromText( wfMessage( 'babel-template', $name )->inContentLanguage()->text() ); -- To view, visit https://gerrit.wikimedia.org/r/262349 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I216f8dd626b938bd3c43b97f18bdeb28eb6f4265 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Babel Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: Hoo man <h...@online.de> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits