Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/262453
Change subject: Add missing RedirectRevisionTest
......................................................................
Add missing RedirectRevisionTest
Change-Id: I732df6b4f7b298d3e3f431db0ec6efe3b8058c52
---
A lib/tests/phpunit/store/RedirectRevisionTest.php
1 file changed, 63 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/53/262453/1
diff --git a/lib/tests/phpunit/store/RedirectRevisionTest.php
b/lib/tests/phpunit/store/RedirectRevisionTest.php
new file mode 100644
index 0000000..4a17ad4
--- /dev/null
+++ b/lib/tests/phpunit/store/RedirectRevisionTest.php
@@ -0,0 +1,63 @@
+<?php
+
+namespace Wikibase\Lib\Tests\Store;
+
+use PHPUnit_Framework_TestCase;
+use Wikibase\DataModel\Entity\EntityRedirect;
+use Wikibase\DataModel\Entity\ItemId;
+use Wikibase\RedirectRevision;
+
+/**
+ * @covers Wikibase\RedirectRevision
+ *
+ * @group Wikibase
+ * @group WikibaseLib
+ * @group WikibaseStore
+ *
+ * @licence GNU GPL v2+
+ * @author Thiemo Mättig
+ */
+class RedirectRevisionTest extends PHPUnit_Framework_TestCase {
+
+ private function newRedirect() {
+ return new EntityRedirect( new ItemId( 'Q1' ), new ItemId( 'Q2'
) );
+ }
+
+ /**
+ * @dataProvider invalidConstructorArgumentsProvider
+ */
+ public function testConstructorThrowsException( $revisionId,
$mwTimestamp ) {
+ $this->setExpectedException( 'InvalidArgumentException' );
+ new RedirectRevision( $this->newRedirect(), $revisionId,
$mwTimestamp );
+ }
+
+ public function invalidConstructorArgumentsProvider() {
+ return array(
+ array( null, '' ),
+ array( true, '' ),
+ array( -1, '' ),
+ array( 0, null ),
+ array( 0, true ),
+ array( 0, 1 ),
+ array( 0, '20141231' ),
+ array( 0, '2014-12-31T00:00:00' ),
+ );
+ }
+
+ public function testGetRedirect() {
+ $redirect = $this->newRedirect();
+ $instance = new RedirectRevision( $redirect );
+ $this->assertSame( $redirect, $instance->getRedirect() );
+ }
+
+ public function testGetRevisionId() {
+ $instance = new RedirectRevision( $this->newRedirect() );
+ $this->assertSame( 0, $instance->getRevisionId() );
+ }
+
+ public function testGetTimestamp() {
+ $instance = new RedirectRevision( $this->newRedirect() );
+ $this->assertSame( '', $instance->getTimestamp() );
+ }
+
+}
--
To view, visit https://gerrit.wikimedia.org/r/262453
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I732df6b4f7b298d3e3f431db0ec6efe3b8058c52
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
