jenkins-bot has submitted this change and it was merged. Change subject: Documentation: Remove paragraph about not creating a 2nd WebRequest ......................................................................
Documentation: Remove paragraph about not creating a 2nd WebRequest WebRequest is no longer required to be a singleton for $wgRequest, thanks to https://gerrit.wikimedia.org/r/144996 Change-Id: Ica629fd28d96f8ee77ee548b0a284abf24b1e780 --- M includes/WebRequest.php 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Chad: Looks good to me, approved jenkins-bot: Verified Objections: Daniel Friesen: There's a problem with this change, please improve diff --git a/includes/WebRequest.php b/includes/WebRequest.php index a1fa0eb..01cf33e 100644 --- a/includes/WebRequest.php +++ b/includes/WebRequest.php @@ -28,11 +28,6 @@ * URL or via a POSTed form stripping illegal input characters and * normalizing Unicode sequences. * - * Usually this is used via a global singleton, $wgRequest. You should - * not create a second WebRequest object; make a FauxRequest object if - * you want to pass arbitrary data to some function in place of the web - * input. - * * @ingroup HTTP */ class WebRequest { -- To view, visit https://gerrit.wikimedia.org/r/149607 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica629fd28d96f8ee77ee548b0a284abf24b1e780 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Withoutaname <[email protected]> Gerrit-Reviewer: Chad <[email protected]> Gerrit-Reviewer: Daniel Friesen <[email protected]> Gerrit-Reviewer: Withoutaname <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
