jenkins-bot has submitted this change and it was merged. Change subject: Setup.php: Ensure that defaults for 'rcdays' and 'watchlistdays' are not invalid ......................................................................
Setup.php: Ensure that defaults for 'rcdays' and 'watchlistdays' are not invalid I ran into this when I set $wgRCMaxAge = 3600*24 (1 day) when testing recent changes stuff. Change-Id: Ib618f0e47f30ebe1ad44f4c70fee5789bfa8c095 --- M includes/Setup.php 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/Setup.php b/includes/Setup.php index c863722..9e4d2a3 100644 --- a/includes/Setup.php +++ b/includes/Setup.php @@ -264,6 +264,7 @@ } unset( $repo ); // no global pollution; destroy reference +$rcMaxAgeDays = $wgRCMaxAge / ( 3600 * 24 ); if ( $wgRCFilterByAge ) { // Trim down $wgRCLinkDays so that it only lists links which are valid // as determined by $wgRCMaxAge. @@ -273,12 +274,22 @@ // @codingStandardsIgnoreStart Generic.CodeAnalysis.ForLoopWithTestFunctionCall.NotAllowed for ( $i = 0; $i < count( $wgRCLinkDays ); $i++ ) { // @codingStandardsIgnoreEnd - if ( $wgRCLinkDays[$i] >= $wgRCMaxAge / ( 3600 * 24 ) ) { + if ( $wgRCLinkDays[$i] >= $rcMaxAgeDays ) { $wgRCLinkDays = array_slice( $wgRCLinkDays, 0, $i + 1, false ); break; } } } +// Ensure that default user options are not invalid, since that breaks Special:Preferences +$wgDefaultUserOptions['rcdays'] = min( + $wgDefaultUserOptions['rcdays'], + ceil( $rcMaxAgeDays ) +); +$wgDefaultUserOptions['watchlistdays'] = min( + $wgDefaultUserOptions['watchlistdays'], + ceil( $rcMaxAgeDays ) +); +unset( $rcMaxAgeDays ); if ( $wgSkipSkin ) { $wgSkipSkins[] = $wgSkipSkin; -- To view, visit https://gerrit.wikimedia.org/r/261357 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib618f0e47f30ebe1ad44f4c70fee5789bfa8c095 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Bartosz DziewoĆski <matma....@gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: Reedy <re...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits