EBernhardson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/262828

Change subject: [elasticsearch] Record per-node fetch timing
......................................................................

[elasticsearch] Record per-node fetch timing

This will allow us to determine average fetch latency for es nodes.
In general within es a search is both a query and a fetch phase, so
whatever information we store about the query phase we should also
store about the fetch phase.

I think we can get away with only the per-node fetch timing, rather
than collecting per query group. The fetch phase is pretty similar
regardless of the query time whereas the query phase varies greatly.

Change-Id: Ice6e8660f452ebe8398f49e6cdbbebd5c75fa82a
---
M modules/elasticsearch/files/monitor/wmfelastic.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/28/262828/1

diff --git a/modules/elasticsearch/files/monitor/wmfelastic.py 
b/modules/elasticsearch/files/monitor/wmfelastic.py
index 2001438..e80cb9e 100644
--- a/modules/elasticsearch/files/monitor/wmfelastic.py
+++ b/modules/elasticsearch/files/monitor/wmfelastic.py
@@ -103,6 +103,8 @@
             'indices.search.query_time_in_millis',
             'indices.search.query_current',
             'indices.search.fetch_total',
+            'indices.search.fetch_time_in_millis',
+            'indices.search.fetch_current',
             'indices.search.groups.more_like.query_total',
             'indices.search.groups.more_like.query_time_in_millis',
             'indices.search.groups.prefix.query_total',

-- 
To view, visit https://gerrit.wikimedia.org/r/262828
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice6e8660f452ebe8398f49e6cdbbebd5c75fa82a
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: EBernhardson <ebernhard...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to