jenkins-bot has submitted this change and it was merged.
Change subject: Use ve.ui.Surface#setDisabled
......................................................................
Use ve.ui.Surface#setDisabled
Depends on Id53c98ba in VisualEditor core.
Change-Id: I8a77342447ed402478ea692f9033cc9f61f28c8d
---
M modules/editor/editors/visualeditor/mw.flow.ve.Target.js
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Catrope: Looks good to me, approved
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/editor/editors/visualeditor/mw.flow.ve.Target.js
b/modules/editor/editors/visualeditor/mw.flow.ve.Target.js
index 16b8339..b828f11 100644
--- a/modules/editor/editors/visualeditor/mw.flow.ve.Target.js
+++ b/modules/editor/editors/visualeditor/mw.flow.ve.Target.js
@@ -67,11 +67,9 @@
};
mw.flow.ve.Target.prototype.setDisabled = function ( disabled ) {
- // TODO upstream this to ve.init.Target
var i, len;
for ( i = 0, len = this.surfaces.length; i < len; i++ ) {
- // T106908: ve.ui.Surface doesn't support setDisabled()
- this.surfaces[ i ][ disabled ? 'disable' : 'enable' ]();
+ this.surfaces[ i ].setDisabled( disabled );
}
};
--
To view, visit https://gerrit.wikimedia.org/r/259284
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a77342447ed402478ea692f9033cc9f61f28c8d
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
