Hoo man has submitted this change and it was merged.

Change subject: Remove duplicate code from statementview.js
......................................................................


Remove duplicate code from statementview.js

Change-Id: I94e0a1154a17e4c0b05f2577d83bda0b3a24afd1
---
M view/resources/jquery/wikibase/jquery.wikibase.statementview.js
1 file changed, 1 insertion(+), 7 deletions(-)

Approvals:
  Hoo man: Verified; Looks good to me, approved



diff --git a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js 
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
index b555063..1136f87 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
@@ -236,13 +236,7 @@
 
                // Group qualifiers by property id:
                if ( qualifiers && qualifiers.length ) {
-                       var propertyIds = qualifiers.getPropertyOrder();
-
-                       groupedQualifierSnaks = [];
-
-                       for ( var i = 0; i < propertyIds.length; i++ ) {
-                               groupedQualifierSnaks.push( 
qualifiers.getFilteredSnakList( propertyIds[i] ) );
-                       }
+                       groupedQualifierSnaks = 
qualifiers.getGroupedSnakLists();
                }
 
                // Using the property id, qualifier snaks are split into groups 
of snaklistviews. These

-- 
To view, visit https://gerrit.wikimedia.org/r/262902
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94e0a1154a17e4c0b05f2577d83bda0b3a24afd1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Hoo man <h...@online.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to