Florianschmidtwelzow has uploaded a new change for review. https://gerrit.wikimedia.org/r/263172
Change subject: Fix undefined index error, when WikidataPageBanner isn't installed ...................................................................... Fix undefined index error, when WikidataPageBanner isn't installed Bug: T123169 Change-Id: If69946ba437b649e8cd61daeba0f8d16f56679be --- M includes/MobileFrontend.hooks.php 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/72/263172/1 diff --git a/includes/MobileFrontend.hooks.php b/includes/MobileFrontend.hooks.php index 9ab887c..a949fb5 100644 --- a/includes/MobileFrontend.hooks.php +++ b/includes/MobileFrontend.hooks.php @@ -698,7 +698,11 @@ $mfMobileUrlTemplate = $context->getMobileUrlTemplate(); $tabletSize = $config->get( 'MFDeviceWidthTablet' ); - if ( $context->isBetaGroupMember() ) { + // show banners using WikidataPageBanner, if installed and all pre-conditions fulfilled + if ( + ExtensionRegistry::getInstance()->isLoaded( 'WikidataPageBanner' ) && + $context->isBetaGroupMember() + ) { // turn default banners on $wgWPBEnableDefaultBanner = true; // Turn on the banner experiment -- To view, visit https://gerrit.wikimedia.org/r/263172 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If69946ba437b649e8cd61daeba0f8d16f56679be Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits