Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/263367
Change subject: Hygiene: DRY up Espresso dependency versions
......................................................................
Hygiene: DRY up Espresso dependency versions
Several Espresso dependencies should be versioned together. Consolidate
the version in a variable and reference appropriately.
Change-Id: I3463d5d1388b77279d37b80cbba13e4683b2d2cc
---
M app/build.gradle
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/67/263367/1
diff --git a/app/build.gradle b/app/build.gradle
index 013520c..7ee4439 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -157,6 +157,7 @@
String okHttpVersion = '2.7.0'
String supportVersion = '23.1.1'
+ String espressoVersion = '2.2.1'
compile "com.android.support:appcompat-v7:$supportVersion" // includes
support-v4
compile "com.android.support:design:$supportVersion"
@@ -189,11 +190,11 @@
androidTestCompile 'com.android.support.test:rules:0.4.1' // JUnit Rules
androidTestCompile 'com.android.support.test:runner:0.4.1' // Android
JUnit Runner
- androidTestCompile 'com.android.support.test.espresso:espresso-core:2.2.1'
+ androidTestCompile
"com.android.support.test.espresso:espresso-core:$espressoVersion"
// Espresso-contrib for DatePicker, RecyclerView, Drawer actions,
Accessibility checks,
// CountingIdlingResource
-
androidTestCompile('com.android.support.test.espresso:espresso-contrib:2.2.1') {
+
androidTestCompile("com.android.support.test.espresso:espresso-contrib:$espressoVersion")
{
//
http://stackoverflow.com/questions/30578243/why-would-adding-espresso-contrib-cause-an-inflateexception
exclude group: 'com.android.support', module: 'appcompat'
exclude group: 'com.android.support', module: 'support-v4'
@@ -201,10 +202,10 @@
}
// Espresso-web for WebView support
- androidTestCompile 'com.android.support.test.espresso:espresso-web:2.2.1'
+ androidTestCompile
"com.android.support.test.espresso:espresso-web:$espressoVersion"
// Espresso-idling-resource for synchronization with background jobs.
- androidTestCompile
'com.android.support.test.espresso:espresso-idling-resource:2.2.1'
+ androidTestCompile
"com.android.support.test.espresso:espresso-idling-resource:$espressoVersion"
}
private setSigningConfigKey(config, Properties props) {
--
To view, visit https://gerrit.wikimedia.org/r/263367
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3463d5d1388b77279d37b80cbba13e4683b2d2cc
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
