jenkins-bot has submitted this change and it was merged.
Change subject: Use .prop instead of .attr for boolean HTML attributes
......................................................................
Use .prop instead of .attr for boolean HTML attributes
Change-Id: I70f97ce2b503a6f97a6df9a50a8197caf78ee1b7
---
M resources/js/ext.translate.quickedit.js
M resources/js/ext.translate.special.pagemigration.js
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/js/ext.translate.quickedit.js
b/resources/js/ext.translate.quickedit.js
index 6f9ea7e..5a51081 100644
--- a/resources/js/ext.translate.quickedit.js
+++ b/resources/js/ext.translate.quickedit.js
@@ -90,7 +90,7 @@
if ( mw.config.get( 'trlKeys' ) || $( '.tqe-inlineeditable'
).length ) {
if ( callbacks.next === undefined ) {
- form.find( '.mw-translate-next,
.mw-translate-skip' ).attr( 'disabled', 'disabled' );
+ form.find( '.mw-translate-next,
.mw-translate-skip' ).prop( 'disabled', true );
} else {
form.find( '.mw-translate-next' ).click(
function () {
if ( callbacks.next ) {
@@ -108,7 +108,7 @@
}
} else {
form.find( '.mw-translate-next, .mw-translate-skip' )
- .attr( 'disabled', 'disabled' )
+ .prop( 'disabled', true )
.css( 'display', 'none' );
}
form.find( '.mw-translate-close' ).click( function () {
diff --git a/resources/js/ext.translate.special.pagemigration.js
b/resources/js/ext.translate.special.pagemigration.js
index cd60d68..f1d2791 100644
--- a/resources/js/ext.translate.special.pagemigration.js
+++ b/resources/js/ext.translate.special.pagemigration.js
@@ -210,7 +210,7 @@
newUnit = $( '<div>' ).addClass( 'mw-tpm-sp-unit row' );
sourceUnit = $( '<textarea>' ).addClass(
'mw-tpm-sp-unit__source five columns' )
- .prop( 'readonly', 'readonly' ).attr( 'tabindex', '-1'
).val( sourceText );
+ .prop( 'readonly', true ).attr( 'tabindex', '-1' ).val(
sourceText );
targetUnit = $( '<textarea>' ).addClass(
'mw-tpm-sp-unit__target five columns' )
.val( targetText );
actionUnit = $( '<div>' ).addClass( 'mw-tpm-sp-unit__actions
two columns' );
@@ -342,7 +342,7 @@
.show( 'fast' );
return;
} else {
- $( 'input' ).attr( 'disabled', 'disabled' );
+ $( 'input' ).prop( 'disabled', true );
for ( i = 0; i < noOfSourceUnits; i++ ) {
content = $( '.mw-tpm-sp-unit__target' ).eq( i
).val();
content = $.trim( content );
@@ -353,7 +353,7 @@
$.ajaxDispatcher( list, 1 ).done( function () {
$( '#action-import' ).removeClass( 'hide' );
- $( 'input' ).removeAttr( 'disabled' );
+ $( 'input' ).prop( 'disabled', false );
} );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/263583
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70f97ce2b503a6f97a6df9a50a8197caf78ee1b7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
