Alexandros Kosiaris has submitted this change and it was merged.
Change subject: pep8 W601: has_key() is deprecated, use not in
......................................................................
pep8 W601: has_key() is deprecated, use not in
Change-Id: I61a7cec8cc72df54e772790340b4c690162a0af0
---
M templates/hadoop/net-topology.py.erb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexandros Kosiaris: Looks good to me, approved
jenkins-bot: Verified
diff --git a/templates/hadoop/net-topology.py.erb
b/templates/hadoop/net-topology.py.erb
index 3ff9d12..67c96f6 100755
--- a/templates/hadoop/net-topology.py.erb
+++ b/templates/hadoop/net-topology.py.erb
@@ -60,7 +60,7 @@
# If the node doesn't have a key in nodes, perhaps it is a
# short hostname or IP address. Look it up!
-if not nodes.has_key(node):
+if node not in nodes:
node = socket.getfqdn(node)
print(nodes.get(node, '/eqiad/default/rack'))
--
To view, visit https://gerrit.wikimedia.org/r/263845
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61a7cec8cc72df54e772790340b4c690162a0af0
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Chad <[email protected]>
Gerrit-Reviewer: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
