jenkins-bot has submitted this change and it was merged. Change subject: Remove patrol config check in User::isAllowed() ......................................................................
Remove patrol config check in User::isAllowed() The isAllowed() function of the User class checks $wgUseRCPatrol and $wgUseNPPatrol in case the action is 'patrol' or 'autopatrol'. Considering we have the useRCPatrol and such functions, it shouldn't. getUserPermissionsErrors of the Title class doesn't and extensions may use patrol regardless of core config. If we don't remove it, we would have to also check the new $wgUseFilePatrol. Change-Id: I671a6b3aa3bd1dc274f2f8e61fb739235ced198c --- M includes/user/User.php 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Bartosz Dziewoński: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/user/User.php b/includes/user/User.php index b406bac..fc34fcc 100644 --- a/includes/user/User.php +++ b/includes/user/User.php @@ -3276,13 +3276,6 @@ if ( $action === '' ) { return true; // In the spirit of DWIM } - // Patrolling may not be enabled - if ( $action === 'patrol' || $action === 'autopatrol' ) { - global $wgUseRCPatrol, $wgUseNPPatrol; - if ( !$wgUseRCPatrol && !$wgUseNPPatrol ) { - return false; - } - } // Use strict parameter to avoid matching numeric 0 accidentally inserted // by misconfiguration: 0 == 'foo' return in_array( $action, $this->getRights(), true ); -- To view, visit https://gerrit.wikimedia.org/r/263555 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I671a6b3aa3bd1dc274f2f8e61fb739235ced198c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Cenarium <cenarium.sy...@gmail.com> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits