Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/263932
Change subject: Avoid races on null revision insertion
......................................................................
Avoid races on null revision insertion
Bug: T51581
Change-Id: I7bfa9a4b20458e76ab3c4659e7041cd68aac13a4
---
M includes/Revision.php
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/32/263932/1
diff --git a/includes/Revision.php b/includes/Revision.php
index 1d7ac72..9373e40 100644
--- a/includes/Revision.php
+++ b/includes/Revision.php
@@ -1628,8 +1628,10 @@
array(
'page_id' => $pageId,
'page_latest=rev_id',
- ),
- __METHOD__ );
+ ),
+ __METHOD__,
+ array( 'FOR UPDATE' ) // T51581
+ );
if ( $current ) {
if ( !$user ) {
--
To view, visit https://gerrit.wikimedia.org/r/263932
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7bfa9a4b20458e76ab3c4659e7041cd68aac13a4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
