Dbrant has uploaded a new change for review. https://gerrit.wikimedia.org/r/264092
Change subject: Prevent possible NPE. ...................................................................... Prevent possible NPE. https://rink.hockeyapp.net/manage/apps/226650/app_versions/8/crash_reasons/99184406 Change-Id: I5e3a0ee49b3ebe77ff8511b67580d7c60a5c7ee2 --- M app/src/main/java/org/wikipedia/page/PageFragment.java 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/92/264092/1 diff --git a/app/src/main/java/org/wikipedia/page/PageFragment.java b/app/src/main/java/org/wikipedia/page/PageFragment.java index f062567..d1d7bd1 100755 --- a/app/src/main/java/org/wikipedia/page/PageFragment.java +++ b/app/src/main/java/org/wikipedia/page/PageFragment.java @@ -844,6 +844,9 @@ @Override public void onCatch(Throwable e) { + if (!isAdded()) { + return; + } /* If anything bad happens during loading of a saved page, then simply bounce it back to the online version of the page, and re-save the page contents locally when it's done. -- To view, visit https://gerrit.wikimedia.org/r/264092 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5e3a0ee49b3ebe77ff8511b67580d7c60a5c7ee2 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Dbrant <dbr...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
