jenkins-bot has submitted this change and it was merged. Change subject: Fix undefined property notice in ChangesList ......................................................................
Fix undefined property notice in ChangesList This comes from ApiQueryWatchlist, which calls ChangesList::isUnpatrolled with recent change row entries. Since If71af587, rc_log_type is now needed along with rc_patrolled. Bug: T123542 Change-Id: If6507121e59c53df925998f383c9bdf8f2936e37 --- M includes/api/ApiQueryWatchlist.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Anomie: Looks good to me, approved Cenarium: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/includes/api/ApiQueryWatchlist.php b/includes/api/ApiQueryWatchlist.php index 75fc33e..ffbd75a 100644 --- a/includes/api/ApiQueryWatchlist.php +++ b/includes/api/ApiQueryWatchlist.php @@ -105,7 +105,7 @@ $this->addFieldsIf( 'rc_user', $this->fld_user || $this->fld_userid ); $this->addFieldsIf( 'rc_user_text', $this->fld_user ); $this->addFieldsIf( 'rc_comment', $this->fld_comment || $this->fld_parsedcomment ); - $this->addFieldsIf( 'rc_patrolled', $this->fld_patrol ); + $this->addFieldsIf( array( 'rc_patrolled', 'rc_log_type' ), $this->fld_patrol ); $this->addFieldsIf( array( 'rc_old_len', 'rc_new_len' ), $this->fld_sizes ); $this->addFieldsIf( 'wl_notificationtimestamp', $this->fld_notificationtimestamp ); $this->addFieldsIf( -- To view, visit https://gerrit.wikimedia.org/r/263921 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6507121e59c53df925998f383c9bdf8f2936e37 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Anomie <bjor...@wikimedia.org> Gerrit-Reviewer: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Cenarium <cenarium.sy...@gmail.com> Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits