jenkins-bot has submitted this change and it was merged. Change subject: Add event logging for Wiktionary popup ......................................................................
Add event logging for Wiktionary popup Schema: https://meta.wikimedia.org/wiki/Schema:MobileWikiAppWiktionaryPopup Bug: T121909 Change-Id: I20ee5380d6c6c784d440a720f923a9a63bd89153 --- A app/src/main/java/org/wikipedia/analytics/WiktionaryDialogFunnel.java M app/src/main/java/org/wikipedia/wiktionary/WiktionaryDialog.java 2 files changed, 39 insertions(+), 0 deletions(-) Approvals: Dbrant: Looks good to me, approved Niedzielski: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/app/src/main/java/org/wikipedia/analytics/WiktionaryDialogFunnel.java b/app/src/main/java/org/wikipedia/analytics/WiktionaryDialogFunnel.java new file mode 100644 index 0000000..13bc3f7 --- /dev/null +++ b/app/src/main/java/org/wikipedia/analytics/WiktionaryDialogFunnel.java @@ -0,0 +1,27 @@ +package org.wikipedia.analytics; + +import android.support.annotation.NonNull; + +import org.json.JSONObject; +import org.wikipedia.WikipediaApp; + +// https://meta.wikimedia.org/wiki/Schema:MobileWikiAppWiktionaryPopup +public class WiktionaryDialogFunnel extends TimedFunnel { + private static final String SCHEMA_NAME = "MobileWikiAppWiktionaryPopup"; + private static final int REV_ID = 15158116; + + private final String text; + + public WiktionaryDialogFunnel(WikipediaApp app, String text) { + super(app, SCHEMA_NAME, REV_ID, app.isProdRelease() ? Funnel.SAMPLE_LOG_100 : Funnel.SAMPLE_LOG_ALL); + this.text = text; + } + + public void logClose() { + log( + "text", text + ); + } + + @Override protected void preprocessSessionToken(@NonNull JSONObject eventData) { } +} diff --git a/app/src/main/java/org/wikipedia/wiktionary/WiktionaryDialog.java b/app/src/main/java/org/wikipedia/wiktionary/WiktionaryDialog.java index 999552c..1ac95cf 100644 --- a/app/src/main/java/org/wikipedia/wiktionary/WiktionaryDialog.java +++ b/app/src/main/java/org/wikipedia/wiktionary/WiktionaryDialog.java @@ -1,5 +1,6 @@ package org.wikipedia.wiktionary; +import android.content.DialogInterface; import android.os.Bundle; import android.support.annotation.NonNull; import android.text.Html; @@ -12,6 +13,8 @@ import org.wikipedia.R; import org.wikipedia.Site; +import org.wikipedia.WikipediaApp; +import org.wikipedia.analytics.WiktionaryDialogFunnel; import org.wikipedia.page.LinkMovementMethodExt; import org.wikipedia.page.PageActivity; import org.wikipedia.page.PageTitle; @@ -48,6 +51,7 @@ private String selectedText; private RbDefinition currentDefinition; private View rootView; + private WiktionaryDialogFunnel funnel; public static WiktionaryDialog newInstance(@NonNull PageTitle title, @NonNull String selectedText) { WiktionaryDialog dialog = new WiktionaryDialog(); @@ -84,9 +88,17 @@ loadDefinitions(); + funnel = new WiktionaryDialogFunnel(WikipediaApp.getInstance(), selectedText); + return rootView; } + @Override + public void onDismiss(DialogInterface dialogInterface) { + super.onDismiss(dialogInterface); + funnel.logClose(); + } + private void loadDefinitions() { PageService contentService = ContentServiceFactory.create(new Site(pageTitle.getSite().getLanguageCode() + WIKTIONARY_DOMAIN)); if (contentService instanceof RbContentService) { -- To view, visit https://gerrit.wikimedia.org/r/260771 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20ee5380d6c6c784d440a720f923a9a63bd89153 Gerrit-PatchSet: 5 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Mholloway <[email protected]> Gerrit-Reviewer: BearND <[email protected]> Gerrit-Reviewer: Brion VIBBER <[email protected]> Gerrit-Reviewer: Dbrant <[email protected]> Gerrit-Reviewer: Mholloway <[email protected]> Gerrit-Reviewer: Niedzielski <[email protected]> Gerrit-Reviewer: Sniedzielski <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
