Cenarium has uploaded a new change for review.
https://gerrit.wikimedia.org/r/264219
Change subject: Autopromotion: remove deprecated onView event, fix INGROUPS
......................................................................
Autopromotion: remove deprecated onView event, fix INGROUPS
This removes the deprecated onView event, which is called in core along
with onEdit only. And this fixes the APCOND_INGROUPS conditions, since
core uses array_slice( $cond, 1 )., not $cond[1]. Some unused extra
arguments are also removed in APCOND_EDITCOUNT.
Change-Id: Iffd3b6282dd069a6100d30fe2bbbfa0716625a2c
---
M wmf-config/CommonSettings.php
M wmf-config/InitialiseSettings.php
2 files changed, 30 insertions(+), 35 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config
refs/changes/19/264219/1
diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index d761400..d98cc4f 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -993,7 +993,6 @@
$wgAutopromoteOnce = array(
'onEdit' => $wmgAutopromoteOnceonEdit,
- 'onView' => $wmgAutopromoteOnceonView,
);
if ( is_array( $wmgExtraImplicitGroups ) ) {
diff --git a/wmf-config/InitialiseSettings.php
b/wmf-config/InitialiseSettings.php
index 4fec76e..0342dd8 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -11115,55 +11115,51 @@
array( APCOND_EDITCOUNT, 200 ),
),
), // T67495
+ 'fawiki' => array(
+ 'uploader' => array( '&',
+ array( APCOND_AGE, 4 * 86400 ),
+ array( APCOND_EDITCOUNT, 10 ),
+ array( '!', array( APCOND_INGROUPS, 'sysop' ) ),
+ array( '!', array( APCOND_INGROUPS, 'bureaucrat' ) ),
+ ),
+ ), // T71171
'trwiki' => array(
'autoreview' => array(
'&', // AND
array( APCOND_AGE, 7*86400 ),
- array( APCOND_EDITCOUNT, 30, 2*86400 ),
- array( 70821 /*APCOND_FR_EDITSUMMARYCOUNT*/, 5 ),
- array( 70823 /*APCOND_FR_UNIQUEPAGECOUNT*/, 5 ),
- array( 70827 /*APCOND_FR_EDITSPACING*/, 7, 7 ),
- array( 70824 /*APCOND_FR_CONTENTEDITCOUNT*/, 20,
2*86400 ),
- array( 70822 /*APCOND_FR_NEVERBOCKED*/ ),
- array( 70829 /*APCOND_FR_MAXREVERTEDEDITRATIO*/, .03 ),
- array( '!', array( APCOND_INGROUPS, array( 'sysop' ) )
),
- array( '!', array( APCOND_INGROUPS, array( 'bureaucrat'
) ) ),
- array( '!', array( APCOND_INGROUPS, array( 'bot' ) ) ),
- array( '!', array( APCOND_INGROUPS, array( 'patroller'
) ) ),
+ array( APCOND_EDITCOUNT, 30 ),
+ array( APCOND_FR_EDITSUMMARYCOUNT, 5 ), /* requires
FlaggedRevs */
+ array( APCOND_FR_UNIQUEPAGECOUNT, 5 ), /* requires
FlaggedRevs */
+ array( APCOND_FR_EDITSPACING, 7, 7 ), /* requires
FlaggedRevs */
+ array( APCOND_FR_CONTENTEDITCOUNT, 20, 2*86400 ), /*
requires FlaggedRevs */
+ array( APCOND_FR_NEVERBOCKED ), /* requires FlaggedRevs
*/
+ array( APCOND_FR_MAXREVERTEDEDITRATIO, .03 ), /*
requires FlaggedRevs */
+ array( '!', array( APCOND_INGROUPS, 'sysop' ) ),
+ array( '!', array( APCOND_INGROUPS, 'bureaucrat' ) ),
+ array( '!', array( APCOND_INGROUPS, 'bot' ) ),
+ array( '!', array( APCOND_INGROUPS, 'patroller' ) ),
),
'patroller' => array(
'&', // AND
array( APCOND_AGE, 15*86400 ),
- array( APCOND_EDITCOUNT, 150, 1*86400 ),
- array( 70821 /*APCOND_FR_EDITSUMMARYCOUNT*/, 25 ),
- array( 70823 /*APCOND_FR_UNIQUEPAGECOUNT*/, 10 ),
- array( 70827 /*APCOND_FR_EDITSPACING*/, 7, 15 ),
- array( 70824 /*APCOND_FR_CONTENTEDITCOUNT*/, 100,
1*86400 ),
- array( 70822 /*APCOND_FR_NEVERBOCKED*/ ),
- array( 70829 /*APCOND_FR_MAXREVERTEDEDITRATIO*/, .03 ),
- array( '!', array( APCOND_INGROUPS, array( 'sysop' ) )
),
- array( '!', array( APCOND_INGROUPS, array( 'bureaucrat'
) ) ),
- array( '!', array( APCOND_INGROUPS, array( 'bot' ) ) ),
+ array( APCOND_EDITCOUNT, 150 ),
+ array( APCOND_FR_EDITSUMMARYCOUNT, 25 ), /* requires
FlaggedRevs */
+ array( APCOND_FR_UNIQUEPAGECOUNT, 10 ), /* requires
FlaggedRevs */
+ array( APCOND_FR_EDITSPACING, 7, 15 ), /* requires
FlaggedRevs */
+ array( APCOND_FR_CONTENTEDITCOUNT, 100, 1*86400 ), /*
requires FlaggedRevs */
+ array( APCOND_FR_NEVERBOCKED ), /* requires FlaggedRevs
*/
+ array( APCOND_FR_MAXREVERTEDEDITRATIO, .03 ), /*
requires FlaggedRevs */
+ array( '!', array( APCOND_INGROUPS, 'sysop' ) ),
+ array( '!', array( APCOND_INGROUPS, 'bureaucrat' ) ),
+ array( '!', array( APCOND_INGROUPS, 'bot' ) ),
),
),
-),
-
-'wmgAutopromoteOnceonView' => array(
- 'default' => array(),
'ruwiki' => array(
'uploader' => array( '&',
- array( APCOND_EDITCOUNT, 20 ),
array( APCOND_AGE, 14 * 86400 ),
+ array( APCOND_EDITCOUNT, 20 ),
),
),
- 'fawiki' => array(
- 'uploader' => array( '&',
- array( APCOND_EDITCOUNT, 10 ),
- array( APCOND_AGE, 4 * 86400 ),
- array( '!', array( APCOND_INGROUPS, array( 'sysop' ) )
),
- array( '!', array( APCOND_INGROUPS, array( 'bureaucrat'
) ) ),
- ),
- ), // T71171
),
'wgAutopromoteOnceLogInRC' => array(
--
To view, visit https://gerrit.wikimedia.org/r/264219
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iffd3b6282dd069a6100d30fe2bbbfa0716625a2c
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Cenarium <cenarium.sy...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
