jenkins-bot has submitted this change and it was merged.
Change subject: Show message about related pages (e.g. /doc) as a warning, not
an error
......................................................................
Show message about related pages (e.g. /doc) as a warning, not an error
Bug: T103753
Change-Id: I31eb0e159aeb5154ce2b507e8dfe19db0c1e2dfd
---
M modules/ext.templateDataGenerator.ui.js
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.templateDataGenerator.ui.js
b/modules/ext.templateDataGenerator.ui.js
index a9f9096..15ba391 100644
--- a/modules/ext.templateDataGenerator.ui.js
+++ b/modules/ext.templateDataGenerator.ui.js
@@ -29,12 +29,14 @@
* Display error message in the edit window
*
* @param {string} msg Message to display
- * @param {string} type Message type 'notice' or 'error'
+ * @param {string} [type='error'] Message type 'notice'
or 'warning' or 'error'
* @param {boolean} [parseHTML] The message should be
parsed
*/
setNoticeMessage: function ( msg, type, parseHTML ) {
type = type || 'error';
- editNoticeLabel.$element.toggleClass(
'errorbox', type === 'error' );
+ editNoticeLabel.$element
+ .toggleClass( 'errorbox', type ===
'error' )
+ .toggleClass( 'warningbox', type ===
'warning' );
if ( parseHTML ) {
// OOUI's label elements do not parse
strings and display them
@@ -250,7 +252,7 @@
mw.messages.set( { 'templatedata-string-exists-hack-message': msg } );
msg =
mw.message( 'templatedata-string-exists-hack-message' ).parse();
-
editArea.setNoticeMessage( msg, 'error', true );
+
editArea.setNoticeMessage( msg, 'warning', true );
}
}
} );
--
To view, visit https://gerrit.wikimedia.org/r/263887
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31eb0e159aeb5154ce2b507e8dfe19db0c1e2dfd
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/TemplateData
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
