jenkins-bot has submitted this change and it was merged.
Change subject: Use MediaWiki\Session\SessionManager instead of deprecated
session handling functions
......................................................................
Use MediaWiki\Session\SessionManager instead of deprecated session handling
functions
session_id() is replaced by ->isPersistent(), and wfSetupSession() by
->persist().
Change-Id: I2ab7cde69043b718ca7ec7ca52412c01310014eb
---
M includes/specials/SpecialGoogleLogin.php
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Anomie: Looks good to me, but someone else must approve
Florianschmidtwelzow: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialGoogleLogin.php
b/includes/specials/SpecialGoogleLogin.php
index 3e12137..95a4c8a 100644
--- a/includes/specials/SpecialGoogleLogin.php
+++ b/includes/specials/SpecialGoogleLogin.php
@@ -35,9 +35,7 @@
// it's possible, that the session isn't started yet (if
GoogleLogin
// replaces MediaWiki login, e.g.)
- if ( session_id() == '' ) {
- wfSetupSession();
- }
+ $this->getRequest()->getSession()->persist();
$this->redirectFromLoginForm( $request, $client );
--
To view, visit https://gerrit.wikimedia.org/r/264097
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ab7cde69043b718ca7ec7ca52412c01310014eb
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/GoogleLogin
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: Anomie <bjor...@wikimedia.org>
Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: Gergő Tisza <gti...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
