Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/264959
Change subject: Don't update the article header for the error page
......................................................................
Don't update the article header for the error page
The article header should not be shown for the error page. The header
was mistakenly updated on configuration change which caused the page to
display as an odd hybrid of error page and the previous wiki page
visited. This patch amends that behavior to only update when not on the
error page.
Bug: T120279
Change-Id: I2b35a6880aca9eda6805d0af1824497b855e22ef
---
M app/src/main/java/org/wikipedia/page/PageFragment.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/59/264959/1
diff --git a/app/src/main/java/org/wikipedia/page/PageFragment.java
b/app/src/main/java/org/wikipedia/page/PageFragment.java
index 7522690..05415e6 100755
--- a/app/src/main/java/org/wikipedia/page/PageFragment.java
+++ b/app/src/main/java/org/wikipedia/page/PageFragment.java
@@ -498,7 +498,7 @@
sendDecorOffsetMessage();
// if the screen orientation changes, then re-layout the lead image
container,
// but only if we've finished fetching the page.
- if (!pageLoadStrategy.isLoading()) {
+ if (!pageLoadStrategy.isLoading() && !errorState) {
pageLoadStrategy.layoutLeadImage();
}
tabsProvider.onConfigurationChanged();
--
To view, visit https://gerrit.wikimedia.org/r/264959
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b35a6880aca9eda6805d0af1824497b855e22ef
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
