Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/265410
Change subject: Don't show warning about already-known parameters that weren't
imported
......................................................................
Don't show warning about already-known parameters that weren't imported
Bug: T124223
Change-Id: Id102799b925ebaec6a1d819f1d2294982c24e407
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M modules/ext.templateDataGenerator.ui.tdDialog.js
4 files changed, 0 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TemplateData
refs/changes/10/265410/1
diff --git a/extension.json b/extension.json
index 93d4251..99af116 100644
--- a/extension.json
+++ b/extension.json
@@ -112,7 +112,6 @@
"templatedata-modal-current-language",
"templatedata-modal-errormsg",
"templatedata-modal-errormsg-import-noparams",
-
"templatedata-modal-errormsg-import-paramsalreadyexist",
"templatedata-modal-format-inline",
"templatedata-modal-format-block",
"templatedata-modal-json-error-replace",
diff --git a/i18n/en.json b/i18n/en.json
index bff7f71..bb23ddd 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -62,7 +62,6 @@
"templatedata-modal-current-language": "Current language: $1",
"templatedata-modal-errormsg": "Errors found. Please make sure there
are no empty or duplicate parameter names, and that the parameter name does not
include \"$1\", \"$2\" or \"$3\".",
"templatedata-modal-errormsg-import-noparams": "No new parameters found
during import.",
- "templatedata-modal-errormsg-import-paramsalreadyexist":
"{{PLURAL:$1|One parameter was not imported, because it already exists|Some
parameters were not imported, because they already exist}} in the editor: $1",
"templatedata-modal-format-inline": "Inline",
"templatedata-modal-format-block": "Block",
"templatedata-modal-json-error-replace": "Replace",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 15278c8..c9a69b4 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -72,7 +72,6 @@
"templatedata-modal-current-language": "Label displaying the current
language in the edit dialog. Parameters:\n* $1 - currently showing
language\n{{Identical|Current language}}",
"templatedata-modal-errormsg": "Error message that appears in the
TemplateData generator GUI in case there are empty, duplicate or invalid
parameter names.\n\nInvalid characters are supplied as parameters to avoid
parsing errors in translation strings.\n\nParameters:\n* $1 - pipe
(<code>|</code>)\n* $2 - equal sign (<code>=</code>)\n* $3 - double curly
brackets (<code><nowiki>}}</nowiki></code>)",
"templatedata-modal-errormsg-import-noparams": "Error message that
appears in the TemplateData generator GUI in case no template parameters were
found during the import attempt.",
- "templatedata-modal-errormsg-import-paramsalreadyexist": "Error message
that appears when some parameters were not imported from the template code
because they already exist in the editor.\n\nParameters:\n* $1 - list of
parameters that were not imported",
"templatedata-modal-format-inline": "Label for inline
format\n{{Identical|Inline}}",
"templatedata-modal-format-block": "Label for block
format\n{{Identical|Block}}",
"templatedata-modal-json-error-replace": "Label for the button in the
error message, agreeing to replace the existing faulty TemplateData string with
a new one.\n{{Identical|Replace}}",
diff --git a/modules/ext.templateDataGenerator.ui.tdDialog.js
b/modules/ext.templateDataGenerator.ui.tdDialog.js
index 825a149..e1fc0df 100644
--- a/modules/ext.templateDataGenerator.ui.tdDialog.js
+++ b/modules/ext.templateDataGenerator.ui.tdDialog.js
@@ -788,10 +788,6 @@
// Repopulate the list
this.repopulateParamSelectWidget();
- if ( response.existing.length > 0 ) {
- combinedMessage.push( mw.msg(
'templatedata-modal-errormsg-import-paramsalreadyexist',
response.existing.join( mw.msg( 'comma-separator' ) ), response.existing.length
) );
- }
-
if ( response.imported.length === 0 ) {
combinedMessage.push( mw.msg(
'templatedata-modal-errormsg-import-noparams' ) );
state = 'error';
--
To view, visit https://gerrit.wikimedia.org/r/265410
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id102799b925ebaec6a1d819f1d2294982c24e407
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TemplateData
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <kren...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
