Niharika29 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/265736
Change subject: Fix broken sorting on Special:GadgetUsage
......................................................................
Fix broken sorting on Special:GadgetUsage
Bug: T123659
Change-Id: Ib16e4d90f7025c94afb3e4e55dba8431c23ccf86
---
M SpecialGadgetUsage.php
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gadgets
refs/changes/36/265736/1
diff --git a/SpecialGadgetUsage.php b/SpecialGadgetUsage.php
index ab93dcd..5a4393d 100644
--- a/SpecialGadgetUsage.php
+++ b/SpecialGadgetUsage.php
@@ -133,7 +133,12 @@
$headers[] = 'gadgetusage-activeusers';
}
foreach( $headers as $h ) {
- $html .= Html::element( 'th', array(), $this->msg( $h
)->text() );
+ if ( $h == 'gadgetusage-gadget' ) {
+ $html .= Html::element( 'th', array(),
$this->msg( $h )->text() );
+ } else {
+ $html .= Html::element( 'th', array(
'data-sort-type' => 'number' ),
+ $this->msg( $h )->text() );
+ }
}
$html .= Html::closeElement( 'tr' );
$this->getOutput()->addHTML( $html );
--
To view, visit https://gerrit.wikimedia.org/r/265736
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib16e4d90f7025c94afb3e4e55dba8431c23ccf86
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gadgets
Gerrit-Branch: master
Gerrit-Owner: Niharika29 <nihar...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
