Alex Monk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/266023

Change subject: Don't die when downloading a file named with unicode characters
......................................................................

Don't die when downloading a file named with unicode characters

Bug: T123031
Change-Id: Ia479878a03a886ea682d468a8c8eb1dd48f5197e
---
M quarry/web/app.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/quarry/web 
refs/changes/23/266023/1

diff --git a/quarry/web/app.py b/quarry/web/app.py
index 6e334d0..6212b3b 100644
--- a/quarry/web/app.py
+++ b/quarry/web/app.py
@@ -266,7 +266,7 @@
             qrun.id,
             format
         )
-        response.headers['Content-Disposition'] = 'attachment; filename="%s"' 
% filename
+        response.headers['Content-Disposition'] = 'attachment; filename="%s"' 
% filename.encode('utf-8')
     response.headers['Access-Control-Allow-Origin'] = '*'
     return response
 

-- 
To view, visit https://gerrit.wikimedia.org/r/266023
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia479878a03a886ea682d468a8c8eb1dd48f5197e
Gerrit-PatchSet: 1
Gerrit-Project: analytics/quarry/web
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to