UltrasonicNXT has submitted this change and it was merged. Change subject: Add PLURAL support for wikiforum-pages ......................................................................
Add PLURAL support for wikiforum-pages Thread: https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Wikiforum-pages/en Change-Id: I2367c8c7df08f4c4670d16ec9575d704182d7bbc --- M WikiForumGui.php M i18n/en.json M i18n/qqq.json 3 files changed, 7 insertions(+), 5 deletions(-) Approvals: UltrasonicNXT: Verified; Looks good to me, approved Nemo bis: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/WikiForumGui.php b/WikiForumGui.php index a85f936..30cf3b5 100644 --- a/WikiForumGui.php +++ b/WikiForumGui.php @@ -82,9 +82,6 @@ $specialPage = SpecialPage::getTitleFor( 'WikiForum' ); if ( $maxissues / $limit > 1 ) { - $output = '<table class="mw-wikiforum-footerrow"><tr><td class="mw-wikiforum-leftside">' . - wfMessage( 'wikiforum-pages' )->text() . wfMessage( 'word-separator' )->plain(); - for ( $i = 1; $i < ( $maxissues / $limit ) + 1; $i++ ) { $urlParams = array_merge( array( 'page' => $i ), $params ); @@ -94,6 +91,11 @@ $pageNumber = $i; } + $output = '<table class="mw-wikiforum-footerrow"><tr><td class="mw-wikiforum-leftside">' . + wfMessage( 'wikiforum-pages' ) + ->numParams( count( $pageNumber ) )->text() . + wfMessage( 'word-separator' )->plain(); + if ( $i != $page + 1 ) { $output .= '<a href="' . htmlspecialchars( $specialPage->getFullURL( $urlParams ) ) . '">' . $pageNumber . '</a>'; } else { diff --git a/i18n/en.json b/i18n/en.json index e7574cf..2f2dc6e 100644 --- a/i18n/en.json +++ b/i18n/en.json @@ -36,7 +36,7 @@ "wikiforum-latest-thread": "Latest thread", "wikiforum-forum": "Forum: $1 > $2", "wikiforum-overview": "Overview", - "wikiforum-pages": "Pages:", + "wikiforum-pages": "{{PLURAL:$1|Page|Pages}}:", "wikiforum-thread-closed": "Thread closed", "wikiforum-new-thread": "New thread", "wikiforum-edit-thread": "Edit thread", diff --git a/i18n/qqq.json b/i18n/qqq.json index 87ffeae..2db98e9 100644 --- a/i18n/qqq.json +++ b/i18n/qqq.json @@ -40,7 +40,7 @@ "wikiforum-latest-thread": "Used as column header of forums list. This column indicates who/when created/edited the latest thread. See {{msg-mw|Wikiforum-by}}.", "wikiforum-forum": "Parameters:\n* $1 is a reply count\n* $2 is a view count.", "wikiforum-overview": "Link text to forum overview.\n{{Identical|Overview}}", - "wikiforum-pages": "Followed by pagination links, like [01] [02] etc.\n{{Identical|Page}}", + "wikiforum-pages": "Followed by pagination links, like [01] [02] etc. Parameters:\n* $1 is page number, for PLURAL support\n{{Identical|Page}}", "wikiforum-thread-closed": "Used in closed thread which was closed by {{msg-mw|Wikiforum-close-thread}} feature.", "wikiforum-new-thread": "Used as tooltip for \"NEW\" icon which indicates the thread is new.", "wikiforum-edit-thread": "Used as tooltip for button.", -- To view, visit https://gerrit.wikimedia.org/r/264466 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2367c8c7df08f4c4670d16ec9575d704182d7bbc Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/WikiForum Gerrit-Branch: master Gerrit-Owner: IoannisKydonis <gianisk...@gmail.com> Gerrit-Reviewer: IoannisKydonis <gianisk...@gmail.com> Gerrit-Reviewer: Nemo bis <federicol...@tiscali.it> Gerrit-Reviewer: Siebrand <siebr...@kitano.nl> Gerrit-Reviewer: UltrasonicNXT <adamr_car...@btinternet.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits