jenkins-bot has submitted this change and it was merged. Change subject: Remove disablement of jQuery.IME on VisualEditor surfaces ......................................................................
Remove disablement of jQuery.IME on VisualEditor surfaces The compositionstart trigger in ContentEditableEntry#replaceTextAtSelection causes ve.ce.Surface#handleInsertion to run, and this appears to be all the VisualEditor integration we need. But if we later decide we need custom TextEntry class, see the earlier revision at https://gerrit.wikimedia.org/r/#/c/264577/3 . Change-Id: Iad6a6eccccdf2ec9822cf7df0f0ace7a95b6bea8 --- M UniversalLanguageSelector.php M extension.json 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Esanders: Looks good to me, approved jenkins-bot: Verified diff --git a/UniversalLanguageSelector.php b/UniversalLanguageSelector.php index 995e26f..437daf8 100644 --- a/UniversalLanguageSelector.php +++ b/UniversalLanguageSelector.php @@ -162,7 +162,7 @@ * * @since 2013.07 */ -$wgULSNoImeSelectors = array( '#wpCaptchaWord', '.ve-ce-surface *' ); +$wgULSNoImeSelectors = array( '#wpCaptchaWord' ); /** * Array of jQuery selectors of elements on which webfonts must not be applied. diff --git a/extension.json b/extension.json index f5925d3..c6dfd9b 100644 --- a/extension.json +++ b/extension.json @@ -80,7 +80,7 @@ ], "@ULSNoImeSelectors": "Array of jQuery selectors of elements on which IME must not be enabled. @since 2013.07", "ULSNoImeSelectors": [ - "#wpCaptchaWord", ".ve-ce-surface *" + "#wpCaptchaWord" ], "@ULSNoWebfontsSelectors": "Array of jQuery selectors of elements on which webfonts must not be applied. By default exclude elements with .autonym because that style set font as Autonym @since 2013.09", "ULSNoWebfontsSelectors": [ -- To view, visit https://gerrit.wikimedia.org/r/264577 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad6a6eccccdf2ec9822cf7df0f0ace7a95b6bea8 Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Divec <da...@troi.org> Gerrit-Reviewer: Amire80 <amir.ahar...@mail.huji.ac.il> Gerrit-Reviewer: Divec <da...@troi.org> Gerrit-Reviewer: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: Santhosh <santhosh.thottin...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
