jenkins-bot has submitted this change and it was merged. Change subject: Remove deprecated HTML elements from SemanticForms ......................................................................
Remove deprecated HTML elements from SemanticForms Remove <big> and <tt> tags. http://www.w3.org/TR/html5/obsolete.html#non-conforming-features Bug: T121911 Change-Id: I8864b8395df2373150b0472cc70eb363b87b3e6a --- M includes/SF_Template.php M specials/SF_CreateForm.php 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Legoktm: Looks good to me, approved Martineznovo: Looks good to me, but someone else must approve D3r1ck01: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/includes/SF_Template.php b/includes/SF_Template.php index b3393fe..a7f7322 100644 --- a/includes/SF_Template.php +++ b/includes/SF_Template.php @@ -169,7 +169,7 @@ // comparable CSS class. $tableText = <<<END {| style="width: 30em; font-size: 90%; border: 1px solid #aaaaaa; background-color: #f9f9f9; color: black; margin-bottom: 0.5em; margin-left: 1em; padding: 0.2em; float: right; clear: right; text-align:left;" -! style="text-align: center; background-color:#ccccff;" colspan="2" |<big>{{PAGENAME}}</big> +! style="text-align: center; background-color:#ccccff;" colspan="2" |<span style="font-size: larger;">{{PAGENAME}}</span> |- END; diff --git a/specials/SF_CreateForm.php b/specials/SF_CreateForm.php index 2cadf50..c418f39 100644 --- a/specials/SF_CreateForm.php +++ b/specials/SF_CreateForm.php @@ -422,9 +422,9 @@ } elseif ( $type == 'enum-list' ) { $cur_values = explode( ',', $cur_value ); foreach ( $param['values'] as $val ) { - $text .= '<span style="white-space: nowrap; padding-right: 5px;"><input type="checkbox" name="p[' . + $text .= '<span style="white-space: nowrap; padding-right: 5px; font-family: monospace;"><input type="checkbox" name="p[' . htmlspecialchars( $paramName ) . '][' . htmlspecialchars( $val ). ']" value="true"' . - ( in_array( $val, $cur_values ) ? ' checked' : '' ) . '/> <tt>' . htmlspecialchars( $val ) . "</tt></span>\n"; + ( in_array( $val, $cur_values ) ? ' checked' : '' ) . '/> ' . htmlspecialchars( $val ) . "</span>\n"; } return $text; } elseif ( $type == 'boolean' ) { -- To view, visit https://gerrit.wikimedia.org/r/266048 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8864b8395df2373150b0472cc70eb363b87b3e6a Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/SemanticForms Gerrit-Branch: master Gerrit-Owner: IoannisKydonis <[email protected]> Gerrit-Reviewer: D3r1ck <[email protected]> Gerrit-Reviewer: D3r1ck01 <[email protected]> Gerrit-Reviewer: IoannisKydonis <[email protected]> Gerrit-Reviewer: Legoktm <[email protected]> Gerrit-Reviewer: Martineznovo <[email protected]> Gerrit-Reviewer: Nemo bis <[email protected]> Gerrit-Reviewer: TheDJ <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
