Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/266270
Change subject: TableSorter: Use SVGs with PNG fallbacks instead of GIFs
......................................................................
TableSorter: Use SVGs with PNG fallbacks instead of GIFs
Also removes the never-used sort_none.gif.
Change-Id: Ia16e19985f68b1d188b4391c1156d61c781059cf
---
M resources/Resources.php
D resources/src/jquery/images/sort_both.gif
A resources/src/jquery/images/sort_both.png
A resources/src/jquery/images/sort_both.svg
D resources/src/jquery/images/sort_down.gif
A resources/src/jquery/images/sort_down.png
A resources/src/jquery/images/sort_down.svg
D resources/src/jquery/images/sort_none.gif
D resources/src/jquery/images/sort_up.gif
A resources/src/jquery/images/sort_up.png
A resources/src/jquery/images/sort_up.svg
D resources/src/jquery/jquery.tablesorter.css
A resources/src/jquery/jquery.tablesorter.less
13 files changed, 32 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/70/266270/1
diff --git a/resources/Resources.php b/resources/Resources.php
index cd9810c..9381752 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -338,7 +338,7 @@
),
'jquery.tablesorter' => array(
'scripts' => 'resources/src/jquery/jquery.tablesorter.js',
- 'styles' => 'resources/src/jquery/jquery.tablesorter.css',
+ 'styles' => 'resources/src/jquery/jquery.tablesorter.less',
'messages' => array( 'sort-descending', 'sort-ascending' ),
'dependencies' => array(
'dom-level2-shim',
diff --git a/resources/src/jquery/images/sort_both.gif
b/resources/src/jquery/images/sort_both.gif
deleted file mode 100644
index 50ad15a..0000000
--- a/resources/src/jquery/images/sort_both.gif
+++ /dev/null
Binary files differ
diff --git a/resources/src/jquery/images/sort_both.png
b/resources/src/jquery/images/sort_both.png
new file mode 100644
index 0000000..e340425
--- /dev/null
+++ b/resources/src/jquery/images/sort_both.png
Binary files differ
diff --git a/resources/src/jquery/images/sort_both.svg
b/resources/src/jquery/images/sort_both.svg
new file mode 100644
index 0000000..f906b93
--- /dev/null
+++ b/resources/src/jquery/images/sort_both.svg
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<svg xmlns="http://www.w3.org/2000/svg"; viewBox="0 0 21 9" height="9"
width="21">
+ <path d="M14.5 5l-4 4-4-4zM14.5 4l-4-4-4 4z"/>
+</svg>
diff --git a/resources/src/jquery/images/sort_down.gif
b/resources/src/jquery/images/sort_down.gif
deleted file mode 100644
index ec4f41b..0000000
--- a/resources/src/jquery/images/sort_down.gif
+++ /dev/null
Binary files differ
diff --git a/resources/src/jquery/images/sort_down.png
b/resources/src/jquery/images/sort_down.png
new file mode 100644
index 0000000..d58d54d
--- /dev/null
+++ b/resources/src/jquery/images/sort_down.png
Binary files differ
diff --git a/resources/src/jquery/images/sort_down.svg
b/resources/src/jquery/images/sort_down.svg
new file mode 100644
index 0000000..105574b
--- /dev/null
+++ b/resources/src/jquery/images/sort_down.svg
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<svg xmlns="http://www.w3.org/2000/svg"; viewBox="0 0 21 4" height="4"
width="21">
+ <path d="M14.5 0l-4 4-4-4z"/>
+</svg>
diff --git a/resources/src/jquery/images/sort_none.gif
b/resources/src/jquery/images/sort_none.gif
deleted file mode 100644
index edd07e5..0000000
--- a/resources/src/jquery/images/sort_none.gif
+++ /dev/null
Binary files differ
diff --git a/resources/src/jquery/images/sort_up.gif
b/resources/src/jquery/images/sort_up.gif
deleted file mode 100644
index 8018918..0000000
--- a/resources/src/jquery/images/sort_up.gif
+++ /dev/null
Binary files differ
diff --git a/resources/src/jquery/images/sort_up.png
b/resources/src/jquery/images/sort_up.png
new file mode 100644
index 0000000..1a5f27e
--- /dev/null
+++ b/resources/src/jquery/images/sort_up.png
Binary files differ
diff --git a/resources/src/jquery/images/sort_up.svg
b/resources/src/jquery/images/sort_up.svg
new file mode 100644
index 0000000..2fa4c73
--- /dev/null
+++ b/resources/src/jquery/images/sort_up.svg
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<svg xmlns="http://www.w3.org/2000/svg"; viewBox="0 0 21 4" height="4"
width="21">
+ <path d="M6.5 4l4-4 4 4z"/>
+</svg>
diff --git a/resources/src/jquery/jquery.tablesorter.css
b/resources/src/jquery/jquery.tablesorter.css
deleted file mode 100644
index a88acc0..0000000
--- a/resources/src/jquery/jquery.tablesorter.css
+++ /dev/null
@@ -1,17 +0,0 @@
-/* Table Sorting */
-table.jquery-tablesorter th.headerSort {
- /* @embed */
- background-image: url(images/sort_both.gif);
- cursor: pointer;
- background-repeat: no-repeat;
- background-position: center right;
- padding-right: 21px;
-}
-table.jquery-tablesorter th.headerSortUp {
- /* @embed */
- background-image: url(images/sort_up.gif);
-}
-table.jquery-tablesorter th.headerSortDown {
- /* @embed */
- background-image: url(images/sort_down.gif);
-}
diff --git a/resources/src/jquery/jquery.tablesorter.less
b/resources/src/jquery/jquery.tablesorter.less
new file mode 100644
index 0000000..f4ef540
--- /dev/null
+++ b/resources/src/jquery/jquery.tablesorter.less
@@ -0,0 +1,19 @@
+@import "mediawiki.mixins";
+
+/* Table Sorting */
+
+table.jquery-tablesorter th.headerSort {
+ .background-image-svg( 'images/sort_both.svg', 'images/sort_both.png' );
+ cursor: pointer;
+ background-repeat: no-repeat;
+ background-position: center right;
+ padding-right: 21px;
+}
+
+table.jquery-tablesorter th.headerSortUp {
+ .background-image-svg( 'images/sort_up.svg', 'images/sort_up.png' );
+}
+
+table.jquery-tablesorter th.headerSortDown {
+ .background-image-svg( 'images/sort_down.svg', 'images/sort_down.png' );
+}
--
To view, visit https://gerrit.wikimedia.org/r/266270
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia16e19985f68b1d188b4391c1156d61c781059cf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
