Ejegg has uploaded a new change for review.
https://gerrit.wikimedia.org/r/266293
Change subject: Quit double-staging Adyen data
......................................................................
Quit double-staging Adyen data
addRequestData already triggers staging, no need to call stageData
again a few lines down.
Change-Id: I55cff94a7fd9c4484d487f892b30f77af22d52e6
---
M adyen_gateway/adyen.adapter.php
1 file changed, 4 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface
refs/changes/93/266293/1
diff --git a/adyen_gateway/adyen.adapter.php b/adyen_gateway/adyen.adapter.php
index c880fda..1db9a3c 100644
--- a/adyen_gateway/adyen.adapter.php
+++ b/adyen_gateway/adyen.adapter.php
@@ -232,7 +232,10 @@
case 'donate':
$formaction = $this->url .
'/hpp/pay.shtml';
$this->runAntifraudHooks();
- $this->addRequestData( array (
'risk_score' => $this->risk_score ) ); //this will also fire off staging again.
+ // Add the risk score to our data. This
will also trigger
+ // staging, placing the risk score in
the constructed URL
+ // as 'offset' for use in
processor-side fraud filters.
+ $this->addRequestData( array (
'risk_score' => $this->risk_score ) );
if ( $this->getValidationAction() !=
'process' ) {
// copied from base class.
$this->logger->info( "Failed
pre-process checks for transaction type $transaction." );
@@ -248,7 +251,6 @@
) );
break;
}
- $this->stageData();
$requestParams =
$this->buildRequestParams();
$this->transaction_response->setData(
array(
--
To view, visit https://gerrit.wikimedia.org/r/266293
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I55cff94a7fd9c4484d487f892b30f77af22d52e6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg <eeggles...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
